diff options
author | Chao Yu <chao@kernel.org> | 2025-05-08 08:14:27 +0300 |
---|---|---|
committer | Jaegeuk Kim <jaegeuk@kernel.org> | 2025-05-08 18:21:58 +0300 |
commit | 43ba56a043b14426ca9ecac875ab357e32cb595e (patch) | |
tree | 23464ca7c3882c07f8bb614406912052f84b704a | |
parent | 0427e811c9bc85e660457487f1da61b1aaf63477 (diff) | |
download | linux-43ba56a043b14426ca9ecac875ab357e32cb595e.tar.xz |
f2fs: fix to return correct error number in f2fs_sync_node_pages()
If __write_node_folio() failed, it will return AOP_WRITEPAGE_ACTIVATE,
the incorrect return value may be passed to userspace in below path,
fix it.
- sync_filesystem
- sync_fs
- f2fs_issue_checkpoint
- block_operations
- f2fs_sync_node_pages
- __write_node_folio
: return AOP_WRITEPAGE_ACTIVATE
Cc: stable@vger.kernel.org
Reported-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
-rw-r--r-- | fs/f2fs/node.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index ec74eb9982a5..69308523c34e 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -2092,10 +2092,14 @@ write_node: ret = __write_node_folio(folio, false, &submitted, wbc, do_balance, io_type, NULL); - if (ret) + if (ret) { folio_unlock(folio); - else if (submitted) + folio_batch_release(&fbatch); + ret = -EIO; + goto out; + } else if (submitted) { nwritten++; + } if (--wbc->nr_to_write == 0) break; |