diff options
| author | Philipp Stanner <phasta@kernel.org> | 2025-11-07 16:57:01 +0300 |
|---|---|---|
| committer | Philipp Stanner <phasta@kernel.org> | 2025-12-02 12:40:40 +0300 |
| commit | 439be5c580e553c8777d5533db5892e773f81d40 (patch) | |
| tree | 7ae7bc30ce51f40d11e3f47b01ce635b6cb52bed | |
| parent | 9d56cbaf12037e8ce7ead9f8f8f9000e4784f2eb (diff) | |
| download | linux-439be5c580e553c8777d5533db5892e773f81d40.tar.xz | |
drm/todo: Add entry for unlocked drm/sched rq readers
Runqueues are currently almost everywhere being read unlocked in
drm/sched. At XDC 2025, the assembled developers were unsure whether
that's legal and whether it can be fixed. Someone should find out.
Add a todo entry for the unlocked runqueue reader problem.
Acked-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Philipp Stanner <phasta@kernel.org>
Link: https://patch.msgid.link/20251107135701.244659-4-phasta@kernel.org
| -rw-r--r-- | Documentation/gpu/todo.rst | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 572a5611dd0c..22487ac1b011 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -909,6 +909,20 @@ Contact: Christian König <christian.koenig@amd.com> Level: Advanced +Add locking for runqueues +------------------------- + +There is an old FIXME by Sima in include/drm/gpu_scheduler.h. It details that +struct drm_sched_rq is read at many places without any locks, not even with a +READ_ONCE. At XDC 2025 no one could really tell why that is the case, whether +locks are needed and whether they could be added. (But for real, that should +probably be locked!). Check whether it's possible to add locks everywhere, and +do so if yes. + +Contact: Philipp Stanner <phasta@kernel.org> + +Level: Intermediate + Outside DRM =========== |