diff options
| author | Yang Yingliang <yangyingliang@huawei.com> | 2021-06-15 04:39:22 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-07-20 17:02:11 +0300 |
| commit | 4376c360a7a59eec758eb93020fdf93fc7301602 (patch) | |
| tree | 7232f2572e0c5b31e5736cf786dcea7fbb01e585 | |
| parent | 8010106d87498ee745bb115e65a87ee7b906fab5 (diff) | |
| download | linux-4376c360a7a59eec758eb93020fdf93fc7301602.tar.xz | |
ASoC: fsl_xcvr: check return value after calling platform_get_resource_byname()
[ Upstream commit a2f6ed4a44721d3a9fdf4da7e0743cb13866bf61 ]
It will cause null-ptr-deref if platform_get_resource_byname() returns NULL,
we need check the return value.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20210615013922.784296-10-yangyingliang@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | sound/soc/fsl/fsl_xcvr.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/sound/soc/fsl/fsl_xcvr.c b/sound/soc/fsl/fsl_xcvr.c index 070e3f32859f..244a35122fbc 100644 --- a/sound/soc/fsl/fsl_xcvr.c +++ b/sound/soc/fsl/fsl_xcvr.c @@ -1205,6 +1205,10 @@ static int fsl_xcvr_probe(struct platform_device *pdev) rx_res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "rxfifo"); tx_res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "txfifo"); + if (!rx_res || !tx_res) { + dev_err(dev, "could not find rxfifo or txfifo resource\n"); + return -EINVAL; + } xcvr->dma_prms_rx.chan_name = "rx"; xcvr->dma_prms_tx.chan_name = "tx"; xcvr->dma_prms_rx.addr = rx_res->start; |