summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohn Ogness <john.ogness@linutronix.de>2025-01-08 00:27:02 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2025-01-10 18:08:25 +0300
commit422c9727b07f9f86e2ec11c56622e566221591cc (patch)
treeeea5342ff162f58da3c81ac6619d125a4d746d1f
parentb63e6f60eab45b16a1bf734fef9035a4c4187cd5 (diff)
downloadlinux-422c9727b07f9f86e2ec11c56622e566221591cc.tar.xz
serial: 8250: Revert "drop lockdep annotation from serial8250_clear_IER()"
The 8250 driver no longer depends on @oops_in_progress and will no longer violate the port->lock locking constraints. This reverts commit 3d9e6f556e235ddcdc9f73600fdd46fe1736b090. Signed-off-by: John Ogness <john.ogness@linutronix.de> Reviewed-by: Petr Mladek <pmladek@suse.com> Link: https://lore.kernel.org/r/20250107212702.169493-7-john.ogness@linutronix.de Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/tty/serial/8250/8250_port.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
index 08466cf10d73..76a8d74f16e8 100644
--- a/drivers/tty/serial/8250/8250_port.c
+++ b/drivers/tty/serial/8250/8250_port.c
@@ -726,6 +726,9 @@ static void __serial8250_clear_IER(struct uart_8250_port *up)
static inline void serial8250_clear_IER(struct uart_8250_port *up)
{
+ /* Port locked to synchronize UART_IER access against the console */
+ lockdep_assert_held_once(&up->port.lock);
+
__serial8250_clear_IER(up);
}