diff options
| author | Ethan Tidmore <ethantidmore06@gmail.com> | 2026-02-26 01:24:53 +0300 |
|---|---|---|
| committer | Namjae Jeon <linkinjeon@kernel.org> | 2026-02-26 12:26:00 +0300 |
| commit | 40c31f0563ec10e5b112be35e2e003f8ce4afe98 (patch) | |
| tree | fca3e2d60b56bfdbc0cb8185f33a51bb702da768 | |
| parent | 2dec6931ee04cab66658a50f6dbe5dd5a2cf4de2 (diff) | |
| download | linux-40c31f0563ec10e5b112be35e2e003f8ce4afe98.tar.xz | |
ntfs: Fix null pointer dereference
The variable ctx can be null and once confirmed to be null in its error
path goes to label err_out. Once there it can be immediately dereferenced
by the function ntfs_attr_put_search_ctx() which has no null pointer check.
Detected by Smatch:
fs/ntfs/ea.c:687 ntfs_new_attr_flags() error:
we previously assumed 'ctx' could be null (see line 577)
Add null pointer check before running ntfs_attr_put_search_ctx() in
error path.
Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
Reviewed-by: Hyunchul Lee <hyc.lee@gmail.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
| -rw-r--r-- | fs/ntfs/ea.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/ntfs/ea.c b/fs/ntfs/ea.c index 82ad9b61ec64..b2b0a9a043a9 100644 --- a/fs/ntfs/ea.c +++ b/fs/ntfs/ea.c @@ -684,7 +684,8 @@ out: a->flags = new_aflags; mark_mft_record_dirty(ctx->ntfs_ino); err_out: - ntfs_attr_put_search_ctx(ctx); + if (ctx) + ntfs_attr_put_search_ctx(ctx); unmap_mft_record(ni); return err; } |