summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarco Nelissen <marco.nelissen@gmail.com>2025-01-09 07:11:50 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2025-01-23 19:22:56 +0300
commit402ce16421477e27f30b57d6d1a6dc248fa3a4e4 (patch)
tree74d68fb3ff1fd07b269e1073060bca20ea184590
parentfdb13258ad86f1235b50cc638ca8914c879ed9bd (diff)
downloadlinux-402ce16421477e27f30b57d6d1a6dc248fa3a4e4.tar.xz
iomap: avoid avoid truncating 64-bit offset to 32 bits
[ Upstream commit c13094b894de289514d84b8db56d1f2931a0bade ] on 32-bit kernels, iomap_write_delalloc_scan() was inadvertently using a 32-bit position due to folio_next_index() returning an unsigned long. This could lead to an infinite loop when writing to an xfs filesystem. Signed-off-by: Marco Nelissen <marco.nelissen@gmail.com> Link: https://lore.kernel.org/r/20250109041253.2494374-1-marco.nelissen@gmail.com Reviewed-by: Darrick J. Wong <djwong@kernel.org> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Christian Brauner <brauner@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--fs/iomap/buffered-io.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
index 25d1ede6bb0e..1bad460275eb 100644
--- a/fs/iomap/buffered-io.c
+++ b/fs/iomap/buffered-io.c
@@ -1138,7 +1138,7 @@ static void iomap_write_delalloc_scan(struct inode *inode,
start_byte, end_byte, iomap, punch);
/* move offset to start of next folio in range */
- start_byte = folio_next_index(folio) << PAGE_SHIFT;
+ start_byte = folio_pos(folio) + folio_size(folio);
folio_unlock(folio);
folio_put(folio);
}