diff options
| author | Wander Lairson Costa <wander@redhat.com> | 2026-02-23 19:17:45 +0300 |
|---|---|---|
| committer | Gabriele Monaco <gmonaco@redhat.com> | 2026-03-31 17:47:50 +0300 |
| commit | 3f305f86373d5940e5105110415e97b4a4c3cf92 (patch) | |
| tree | a8729d8d0fcc5e7181af196e0145ca0054581313 | |
| parent | a115ee5a32275d5f171506dc65e2130e218d2117 (diff) | |
| download | linux-3f305f86373d5940e5105110415e97b4a4c3cf92.tar.xz | |
rv/rvgen: remove bare except clauses in generator
Remove bare except clauses from the generator module that were
catching all exceptions including KeyboardInterrupt and SystemExit.
This follows the same exception handling improvements made in the
previous AutomataError commit and addresses PEP 8 violations.
The bare except clause in __create_directory was silently catching
and ignoring all errors after printing a message, which could mask
serious issues. For __write_file, the bare except created a critical
bug where the file variable could remain undefined if open() failed,
causing a NameError when attempting to write to or close the file.
These methods now let OSError propagate naturally, allowing callers
to handle file system errors appropriately. This provides clearer
error reporting and allows Python's exception handling to show
complete stack traces with proper error types and locations.
Signed-off-by: Wander Lairson Costa <wander@redhat.com>
Reviewed-by: Nam Cao <namcao@linutronix.de>
Reviewed-by: Gabriele Monaco <gmonaco@redhat.com>
Link: https://lore.kernel.org/r/20260223162407.147003-3-wander@redhat.com
Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
| -rw-r--r-- | tools/verification/rvgen/rvgen/generator.py | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/tools/verification/rvgen/rvgen/generator.py b/tools/verification/rvgen/rvgen/generator.py index 571093a92bdc..a2391a4c21ed 100644 --- a/tools/verification/rvgen/rvgen/generator.py +++ b/tools/verification/rvgen/rvgen/generator.py @@ -198,17 +198,10 @@ obj-$(CONFIG_RV_MON_%s) += monitors/%s/%s.o os.mkdir(path) except FileExistsError: return - except: - print("Fail creating the output dir: %s" % self.name) def __write_file(self, file_name, content): - try: - file = open(file_name, 'w') - except: - print("Fail writing to file: %s" % file_name) - + file = open(file_name, 'w') file.write(content) - file.close() def _create_file(self, file_name, content): |