diff options
| author | Jork Loeser <jloeser@linux.microsoft.com> | 2026-04-08 04:36:38 +0300 |
|---|---|---|
| committer | Wei Liu <wei.liu@kernel.org> | 2026-04-22 09:23:25 +0300 |
| commit | 3c42b33433796b73ddecd8f60bda419b1648d997 (patch) | |
| tree | 995ac65182c5bc023f614e637b5aab8ad33a19aa | |
| parent | cfc42685e5700e33bb25911d556b2727479de97c (diff) | |
| download | linux-3c42b33433796b73ddecd8f60bda419b1648d997.tar.xz | |
Drivers: hv: vmbus: fix hyperv_cpuhp_online variable shadowing
vmbus_alloc_synic_and_connect() declares a local 'int
hyperv_cpuhp_online' that shadows the file-scope global of the same
name. The cpuhp state returned by cpuhp_setup_state() is stored in
the local, leaving the global at 0 (CPUHP_OFFLINE). When
hv_kexec_handler() or hv_machine_shutdown() later call
cpuhp_remove_state(hyperv_cpuhp_online) they pass 0, which hits the
BUG_ON in __cpuhp_remove_state_cpuslocked().
Remove the local declaration so the cpuhp state is stored in the
file-scope global where hv_kexec_handler() and hv_machine_shutdown()
expect it.
Fixes: 2647c96649ba ("Drivers: hv: Support establishing the confidential VMBus connection")
Signed-off-by: Jork Loeser <jloeser@linux.microsoft.com>
Reviewed-by: Stanislav Kinsburskii <skinsburskii@linux.microsoft.com>
Reviewed-by: Anirudh Rayabharam (Microsoft) <anirudh@anirudhrb.com>
Signed-off-by: Wei Liu <wei.liu@kernel.org>
| -rw-r--r-- | drivers/hv/vmbus_drv.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c index 24fa0b2443c3..463eb818549e 100644 --- a/drivers/hv/vmbus_drv.c +++ b/drivers/hv/vmbus_drv.c @@ -1423,7 +1423,6 @@ static int vmbus_alloc_synic_and_connect(void) { int ret, cpu; struct work_struct __percpu *works; - int hyperv_cpuhp_online; ret = hv_synic_alloc(); if (ret < 0) |