diff options
| author | Cai Huoqing <caihuoqing@baidu.com> | 2021-09-17 07:22:07 +0300 |
|---|---|---|
| committer | Helge Deller <deller@gmx.de> | 2022-01-30 01:22:36 +0300 |
| commit | 394e80c8c68df4684ac43cb09e315f126db7534f (patch) | |
| tree | 6ba62661acef5fa46deb8c4dc98cad53dddd902e | |
| parent | 0d3dbeb8142a92bb571c74b4e78f326b742fea64 (diff) | |
| download | linux-394e80c8c68df4684ac43cb09e315f126db7534f.tar.xz | |
video: fbdev: da8xx-fb: Make use of the helper function dev_err_probe()
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Signed-off-by: Helge Deller <deller@gmx.de>
| -rw-r--r-- | drivers/video/fbdev/da8xx-fb.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/video/fbdev/da8xx-fb.c b/drivers/video/fbdev/da8xx-fb.c index 005ac3c17aa1..ae76a2111c77 100644 --- a/drivers/video/fbdev/da8xx-fb.c +++ b/drivers/video/fbdev/da8xx-fb.c @@ -1354,10 +1354,9 @@ static int fb_probe(struct platform_device *device) return PTR_ERR(da8xx_fb_reg_base); tmp_lcdc_clk = devm_clk_get(&device->dev, "fck"); - if (IS_ERR(tmp_lcdc_clk)) { - dev_err(&device->dev, "Can not get device clock\n"); - return PTR_ERR(tmp_lcdc_clk); - } + if (IS_ERR(tmp_lcdc_clk)) + return dev_err_probe(&device->dev, PTR_ERR(tmp_lcdc_clk), + "Can not get device clock\n"); pm_runtime_enable(&device->dev); pm_runtime_get_sync(&device->dev); |