summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAntheas Kapenekakis <lkml@antheas.dev>2025-04-25 14:18:17 +0300
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>2025-04-30 14:05:41 +0300
commit38b30882c6215c061159fb0544644d39e9bd3d03 (patch)
tree9178c6a71c0536862ab735d99f5a72f0ad3baf38
parent36a65fa84ac30b8df25799dfcedda76dfd7d087b (diff)
downloadlinux-38b30882c6215c061159fb0544644d39e9bd3d03.tar.xz
platform/x86: oxpec: Follow reverse xmas convention for tt_toggle
Since the rest of the driver follows this convention, apply it to the tt_toggle attribute as well. Suggested-by: Derek J. Clark <derekjohn.clark@gmail.com> Reviewed-by: Thomas Weißschuh <linux@weissschuh.net> Reviewed-by: Derek J. Clark <derekjohn.clark@gmail.com> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev> Link: https://lore.kernel.org/r/20250425111821.88746-13-lkml@antheas.dev Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
-rw-r--r--drivers/platform/x86/oxpec.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/platform/x86/oxpec.c b/drivers/platform/x86/oxpec.c
index 45dfe0a7578b..96e9b7205be4 100644
--- a/drivers/platform/x86/oxpec.c
+++ b/drivers/platform/x86/oxpec.c
@@ -275,9 +275,9 @@ static const struct dmi_system_id dmi_table[] = {
/* Helper functions to handle EC read/write */
static int read_from_ec(u8 reg, int size, long *val)
{
- int i;
- int ret;
u8 buffer;
+ int ret;
+ int i;
if (!lock_global_acpi_lock())
return -EBUSY;
@@ -389,8 +389,8 @@ static ssize_t tt_toggle_store(struct device *dev,
struct device_attribute *attr, const char *buf,
size_t count)
{
- int rval;
bool value;
+ int rval;
rval = kstrtobool(buf, &value);
if (rval)
@@ -411,8 +411,8 @@ static ssize_t tt_toggle_show(struct device *dev,
struct device_attribute *attr, char *buf)
{
int retval;
- u8 reg;
long val;
+ u8 reg;
switch (board) {
case oxp_mini_amd_a07: