diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2026-06-09 21:32:22 +0300 |
|---|---|---|
| committer | Paolo Abeni <pabeni@redhat.com> | 2026-06-11 13:55:23 +0300 |
| commit | 3500dfa6ff0e658f10fa7c87d8be557cefa3d1bb (patch) | |
| tree | 413ea774327db2b06b8bf7222ce747a379ed6623 | |
| parent | f26cddcf2a8a997c6c1e73101160197c3dead435 (diff) | |
| download | linux-3500dfa6ff0e658f10fa7c87d8be557cefa3d1bb.tar.xz | |
net: shaper: drop unnecessary kfree_rcu in pre_insert
If we fail to insert a node into the XArray in net_shaper_pre_insert()
we can free it directly - it was never visible to the RCU readers.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Link: https://patch.msgid.link/20260609183224.1108521-3-kuba@kernel.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
| -rw-r--r-- | net/shaper/shaper.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/shaper/shaper.c b/net/shaper/shaper.c index a5b42b697a93..33958462e5e9 100644 --- a/net/shaper/shaper.c +++ b/net/shaper/shaper.c @@ -406,7 +406,7 @@ static int net_shaper_pre_insert(struct net_shaper_binding *binding, prev = xa_store(&hierarchy->shapers, index, cur, GFP_KERNEL); if (xa_err(prev)) { NL_SET_ERR_MSG(extack, "Can't insert shaper into device store"); - kfree_rcu(cur, rcu); + kfree(cur); ret = xa_err(prev); goto free_id; } |