diff options
| author | Xuanqiang Luo <luoxuanqiang@kylinos.cn> | 2025-11-05 23:19:57 +0300 |
|---|---|---|
| committer | Frederic Weisbecker <frederic@kernel.org> | 2025-11-06 02:03:06 +0300 |
| commit | 34e82569d59391bf7d808a558ff631c4428b026d (patch) | |
| tree | cf6977fee65b76fdf70895fa0d7969d14713df1f | |
| parent | e52b43883d084a9af263c573f2a1bd1ca5088389 (diff) | |
| download | linux-34e82569d59391bf7d808a558ff631c4428b026d.tar.xz | |
rcu: use WRITE_ONCE() for ->next and ->pprev of hlist_nulls
In rculist_nulls.h we can still see ordinary assignments to ->pprev and
->next of hlist_nulls.
As noted in the two patches below:
commit efd04f8a8b45 ("rcu: Use WRITE_ONCE() for assignments to ->next for
rculist_nulls")
commit 860c8802ace1 ("rcu: Use WRITE_ONCE() for assignments to ->pprev for
hlist_nulls")
We should use WRITE_ONCE().
Signed-off-by: Xuanqiang Luo <luoxuanqiang@kylinos.cn>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
| -rw-r--r-- | include/linux/rculist_nulls.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/include/linux/rculist_nulls.h b/include/linux/rculist_nulls.h index 89186c499dd4..d5a656cc4c6a 100644 --- a/include/linux/rculist_nulls.h +++ b/include/linux/rculist_nulls.h @@ -138,7 +138,7 @@ static inline void hlist_nulls_add_tail_rcu(struct hlist_nulls_node *n, if (last) { WRITE_ONCE(n->next, last->next); - n->pprev = &last->next; + WRITE_ONCE(n->pprev, &last->next); rcu_assign_pointer(hlist_nulls_next_rcu(last), n); } else { hlist_nulls_add_head_rcu(n, h); @@ -148,8 +148,8 @@ static inline void hlist_nulls_add_tail_rcu(struct hlist_nulls_node *n, /* after that hlist_nulls_del will work */ static inline void hlist_nulls_add_fake(struct hlist_nulls_node *n) { - n->pprev = &n->next; - n->next = (struct hlist_nulls_node *)NULLS_MARKER(NULL); + WRITE_ONCE(n->pprev, &n->next); + WRITE_ONCE(n->next, (struct hlist_nulls_node *)NULLS_MARKER(NULL)); } /** |