summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichal Piekos <michal.piekos@mmpsystems.pl>2026-03-01 19:46:31 +0300
committerLinus Walleij <linusw@kernel.org>2026-03-03 10:30:33 +0300
commit33d4feff673bb32d3c94a6f25e7ca0be966ef410 (patch)
tree20fb3115654f23adc1f7131579fb560c0b72ab6e
parentcc2f5e2aeb6c69556837e45756b3ddded98b3898 (diff)
downloadlinux-33d4feff673bb32d3c94a6f25e7ca0be966ef410.tar.xz
pinctrl: core: use dev_err_probe() when applying state
When applying a pinctrl state, -EPROBE_DEFER may be returned if dependencies are not ready and the consumer will retry probing. This is normal probe ordering behaviour and not a real error. However, pinctrl core currently logs: "Error applying setting, reverse things back" even when the return value is -EPROBE_DEFER, resulting in noisy boot-time error messages. Replace dev_err() with dev_err_probe() to handle -EPROBE_DEFER consistently and suppress error logging for deferred probes. No functional change intended. Signed-off-by: Michal Piekos <michal.piekos@mmpsystems.pl> Signed-off-by: Linus Walleij <linusw@kernel.org>
-rw-r--r--drivers/pinctrl/core.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index b5e97689589f..2edc9bdad183 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -1350,7 +1350,8 @@ unapply_mux_setting:
goto restore_old_state;
unapply_new_state:
- dev_err(p->dev, "Error applying setting, reverse things back\n");
+ dev_err_probe(p->dev, ret,
+ "Error applying setting, reverse things back\n");
/*
* All we can do here is pinmux_disable_setting.