diff options
| author | Vijendar Mukunda <Vijendar.Mukunda@amd.com> | 2024-03-29 08:38:12 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2024-03-29 16:59:35 +0300 |
| commit | 2c603a4947a1247102ccb008d5eb6f37a4043c98 (patch) | |
| tree | 8f07e83062969cc6d6293a8d2441e68009b56e72 | |
| parent | e48ef677000ba5d914711d8aaf1459df72522681 (diff) | |
| download | linux-2c603a4947a1247102ccb008d5eb6f37a4043c98.tar.xz | |
ASoC: amd: acp: fix for acp_init function error handling
If acp_init() fails, acp pci driver probe should return error.
Add acp_init() function return value check logic.
Fixes: e61b415515d3 ("ASoC: amd: acp: refactor the acp init and de-init sequence")
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Link: https://lore.kernel.org/r/20240329053815.2373979-1-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/amd/acp/acp-pci.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/sound/soc/amd/acp/acp-pci.c b/sound/soc/amd/acp/acp-pci.c index 440b91d4f261..5f35b90eab8d 100644 --- a/sound/soc/amd/acp/acp-pci.c +++ b/sound/soc/amd/acp/acp-pci.c @@ -115,7 +115,10 @@ static int acp_pci_probe(struct pci_dev *pci, const struct pci_device_id *pci_id goto unregister_dmic_dev; } - acp_init(chip); + ret = acp_init(chip); + if (ret) + goto unregister_dmic_dev; + res = devm_kcalloc(&pci->dev, num_res, sizeof(struct resource), GFP_KERNEL); if (!res) { ret = -ENOMEM; |