diff options
| author | John Ogness <john.ogness@linutronix.de> | 2018-06-24 01:32:10 +0300 |
|---|---|---|
| committer | Johan Hovold <johan@kernel.org> | 2018-06-26 15:52:15 +0300 |
| commit | 2ba02c8dd063c4396111629e96dec5a3f231f995 (patch) | |
| tree | dda96ac6dd6f9a333ab7edcda53f8877b7727d7e | |
| parent | 19bfbf462e8921d8e520bcc0a23ebc4988223631 (diff) | |
| download | linux-2ba02c8dd063c4396111629e96dec5a3f231f995.tar.xz | |
USB: serial: quatech2: use irqsave() in USB's complete callback
The USB completion callback does not disable interrupts while acquiring
the lock. We want to remove the local_irq_disable() invocation from
__usb_hcd_giveback_urb() and therefore it is required for the callback
handler to disable the interrupts while acquiring the lock.
The callback may be invoked either in IRQ or BH context depending on the
USB host controller.
Use the _irqsave() variant of the locking primitives.
Signed-off-by: John Ogness <john.ogness@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Johan Hovold <johan@kernel.org>
| -rw-r--r-- | drivers/usb/serial/quatech2.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/usb/serial/quatech2.c b/drivers/usb/serial/quatech2.c index ff2322ea5e14..b61c2a9b6b11 100644 --- a/drivers/usb/serial/quatech2.c +++ b/drivers/usb/serial/quatech2.c @@ -621,16 +621,17 @@ static void qt2_write_bulk_callback(struct urb *urb) { struct usb_serial_port *port; struct qt2_port_private *port_priv; + unsigned long flags; port = urb->context; port_priv = usb_get_serial_port_data(port); - spin_lock(&port_priv->urb_lock); + spin_lock_irqsave(&port_priv->urb_lock, flags); port_priv->urb_in_use = false; usb_serial_port_softint(port); - spin_unlock(&port_priv->urb_lock); + spin_unlock_irqrestore(&port_priv->urb_lock, flags); } |