summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIan Abbott <abbotti@mev.co.uk>2026-01-30 19:47:36 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2026-04-02 16:49:37 +0300
commit2750aecdf60524a7d58ecdaaa6e9728ad008cadb (patch)
tree8763eb87eba567ffc0d0924ba41254d9a5596d40
parent118fb051de0129e0565880119dd7fe64b233f969 (diff)
downloadlinux-2750aecdf60524a7d58ecdaaa6e9728ad008cadb.tar.xz
comedi: dac02: Add sanity checks for I/O base address
The "dac02" driver uses an admin-supplied configuration option (`it->options[0]`) to configure the I/O port base address of a supported DAC-02 board. It currently allows any base address to be configured but the hardware only supports base addresses (configured by an on-board DIP switch) in the range 0x200 to 0x3f8 on 8-byte boundaries. Add a sanity check to ensure the device is not configured at an unsupported base address. Signed-off-by: Ian Abbott <abbotti@mev.co.uk> Link: https://patch.msgid.link/20260130170416.49994-12-abbotti@mev.co.uk Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/comedi/drivers/dac02.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/comedi/drivers/dac02.c b/drivers/comedi/drivers/dac02.c
index 4b011d66d7b0..2c04472c5078 100644
--- a/drivers/comedi/drivers/dac02.c
+++ b/drivers/comedi/drivers/dac02.c
@@ -103,7 +103,8 @@ static int dac02_attach(struct comedi_device *dev, struct comedi_devconfig *it)
struct comedi_subdevice *s;
int ret;
- ret = comedi_request_region(dev, it->options[0], 0x08);
+ ret = comedi_check_request_region(dev, it->options[0], 0x08,
+ 0x200, 0x3ff, 8);
if (ret)
return ret;