summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIan Abbott <abbotti@mev.co.uk>2026-01-30 19:47:56 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2026-04-02 16:49:39 +0300
commit2555cab1cb79fe41fadca2eaf6674fddaf5f1404 (patch)
treeb237627447f01a0aae2d4c6a9f98408e8f80203e
parentdf05bcfcbd32669dfa7e3d4a3d0f0b46ded5e61a (diff)
downloadlinux-2555cab1cb79fe41fadca2eaf6674fddaf5f1404.tar.xz
comedi: ni_labpc: Add sanity checks for I/O base address
The "ni_labpc" driver uses an admin-supplied configuration option (`it->options[0]`) to configure the I/O port base address of a Lab-PC-1200 series or Lab-PC+ board. It currently allows any base address to be configured but the hardware only supports base addresses (configured by a configuration utility and stored in nonvolatile memory) in the range 0 to 0x3E0 on 32-byte boundaries. Add a sanity check to ensure the device is not configured at an unsupported base address. Signed-off-by: Ian Abbott <abbotti@mev.co.uk> Link: https://patch.msgid.link/20260130170416.49994-32-abbotti@mev.co.uk Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/comedi/drivers/ni_labpc.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/comedi/drivers/ni_labpc.c b/drivers/comedi/drivers/ni_labpc.c
index b25a8e117072..93b5333a99b5 100644
--- a/drivers/comedi/drivers/ni_labpc.c
+++ b/drivers/comedi/drivers/ni_labpc.c
@@ -78,7 +78,8 @@ static int labpc_attach(struct comedi_device *dev, struct comedi_devconfig *it)
unsigned int dma_chan = it->options[2];
int ret;
- ret = comedi_request_region(dev, it->options[0], 0x20);
+ ret = comedi_check_request_region(dev, it->options[0], 0x20,
+ 0, 0x3ff, 32);
if (ret)
return ret;