diff options
| author | Felix Kuehling <Felix.Kuehling@amd.com> | 2022-02-19 01:25:23 +0300 |
|---|---|---|
| committer | Alex Deucher <alexander.deucher@amd.com> | 2022-02-22 22:40:44 +0300 |
| commit | 22804e03f7a5ed35d86721d037bbf52fbfd0369f (patch) | |
| tree | e02bb4f01e595df54f4172678d2110974b7eea8f | |
| parent | 757f9e4dd51644729d27c9b5e56f75681e8f17d0 (diff) | |
| download | linux-22804e03f7a5ed35d86721d037bbf52fbfd0369f.tar.xz | |
drm/amdkfd: Fix criu_restore_bo error handling
Clang static analysis reports this problem
kfd_chardev.c:2327:2: warning: 1st function call argument
is an uninitialized value
kvfree(bo_privs);
^~~~~~~~~~~~~~~~
Make sure bo_buckets and bo_privs are initialized so freeing them in the
error handling code path will never result in undefined behaviour.
Fixes: 73fa13b6a511 ("drm/amdkfd: CRIU Implement KFD restore ioctl")
Reported-by: Tom Rix <trix@redhat.com>
Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
Reviewed-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
| -rw-r--r-- | drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c index 965af2a08bc0..7affec907fd1 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c @@ -2097,8 +2097,8 @@ static int criu_restore_bos(struct kfd_process *p, uint64_t *priv_offset, uint64_t max_priv_data_size) { - struct kfd_criu_bo_bucket *bo_buckets; - struct kfd_criu_bo_priv_data *bo_privs; + struct kfd_criu_bo_bucket *bo_buckets = NULL; + struct kfd_criu_bo_priv_data *bo_privs = NULL; const bool criu_resume = true; bool flush_tlbs = false; int ret = 0, j = 0; |