diff options
| author | Kuniyuki Iwashima <kuniyu@amazon.com> | 2025-01-14 11:13:52 +0300 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2025-01-16 01:20:08 +0300 |
| commit | 2248c05340a6aa449efa4b12fca7ce490f32bda9 (patch) | |
| tree | aaa6204052b993727e9dd7167a3927f3ab6290cf | |
| parent | 7a649f39dab77b494b2b2dd38153d0ba7b037c4b (diff) | |
| download | linux-2248c05340a6aa449efa4b12fca7ce490f32bda9.tar.xz | |
net: loopback: Hold rtnl_net_lock() in blackhole_netdev_init().
blackhole_netdev is the global device in init_net.
Let's hold rtnl_net_lock(&init_net) in blackhole_netdev_init().
While at it, the unnecessary dev_net_set() call is removed, which
is done in alloc_netdev_mqs().
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Link: https://patch.msgid.link/20250114081352.47404-1-kuniyu@amazon.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | drivers/net/loopback.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c index 1993b90b1a5f..c8840c3b9a1b 100644 --- a/drivers/net/loopback.c +++ b/drivers/net/loopback.c @@ -264,13 +264,12 @@ static int __init blackhole_netdev_init(void) if (!blackhole_netdev) return -ENOMEM; - rtnl_lock(); + rtnl_net_lock(&init_net); dev_init_scheduler(blackhole_netdev); dev_activate(blackhole_netdev); - rtnl_unlock(); + rtnl_net_unlock(&init_net); blackhole_netdev->flags |= IFF_UP | IFF_RUNNING; - dev_net_set(blackhole_netdev, &init_net); return 0; } |