diff options
| author | Faisal Bukhari <faisalbukhari523@gmail.com> | 2025-09-22 21:08:34 +0300 |
|---|---|---|
| committer | Namhyung Kim <namhyung@kernel.org> | 2026-01-07 01:54:24 +0300 |
| commit | 1eb217ab2e737609f8a861b517649e82e7236d05 (patch) | |
| tree | 47575d155dad641651835c86adee4d1c119c3cb7 | |
| parent | fe072f651083c612278de82ce08bccdfecf574b3 (diff) | |
| download | linux-1eb217ab2e737609f8a861b517649e82e7236d05.tar.xz | |
perf parse-events: Fix evsel allocation failure
If evsel__new_idx() returns NULL, the function currently jumps to label
'out_err'. Here, references to `cpus` and `pmu_cpus` are dropped.
Also, resources held by evsel->name and evsel->metric_id are freed.
But if evsel__new_idx() returns NULL, it can lead to NULL pointer
dereference.
Fixes: cd63c22168257a0b ("perf parse-events: Minor __add_event refactoring")
Signed-off-by: Faisal Bukhari <faisalbukhari523@gmail.com>
Reviewed-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
| -rw-r--r-- | tools/perf/util/parse-events.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c index 17c1c36a7bf9..000c89a1e50d 100644 --- a/tools/perf/util/parse-events.c +++ b/tools/perf/util/parse-events.c @@ -251,8 +251,11 @@ __add_event(struct list_head *list, int *idx, event_attr_init(attr); evsel = evsel__new_idx(attr, *idx); - if (!evsel) - goto out_err; + if (!evsel) { + perf_cpu_map__put(cpus); + perf_cpu_map__put(pmu_cpus); + return NULL; + } if (name) { evsel->name = strdup(name); |