diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2025-09-02 09:33:36 +0300 |
|---|---|---|
| committer | Bjorn Andersson <andersson@kernel.org> | 2025-09-04 16:36:57 +0300 |
| commit | 1e50f5c9965252ed6657b8692cd7366784d60616 (patch) | |
| tree | dbb852b9d0ab40e19e5ddbda8181ee9d1e36565a | |
| parent | 0e56e3369b60506ac030546c8a63a1aef153d486 (diff) | |
| download | linux-1e50f5c9965252ed6657b8692cd7366784d60616.tar.xz | |
clk: qcom: common: Fix NULL vs IS_ERR() check in qcom_cc_icc_register()
The devm_clk_hw_get_clk() function doesn't return NULL, it returns error
pointers. Update the checking to match.
Fixes: 8737ec830ee3 ("clk: qcom: common: Add interconnect clocks support")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Imran Shaik <imran.shaik@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/aLaPwL2gFS85WsfD@stanley.mountain
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
| -rw-r--r-- | drivers/clk/qcom/common.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/clk/qcom/common.c b/drivers/clk/qcom/common.c index 37c3008e6c1b..121591886774 100644 --- a/drivers/clk/qcom/common.c +++ b/drivers/clk/qcom/common.c @@ -277,8 +277,8 @@ static int qcom_cc_icc_register(struct device *dev, icd[i].slave_id = desc->icc_hws[i].slave_id; hws = &desc->clks[desc->icc_hws[i].clk_id]->hw; icd[i].clk = devm_clk_hw_get_clk(dev, hws, "icc"); - if (!icd[i].clk) - return dev_err_probe(dev, -ENOENT, + if (IS_ERR(icd[i].clk)) + return dev_err_probe(dev, PTR_ERR(icd[i].clk), "(%d) clock entry is null\n", i); icd[i].name = clk_hw_get_name(hws); } |