summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohannes Berg <johannes.berg@intel.com>2025-03-19 21:44:25 +0300
committerJohannes Berg <johannes.berg@intel.com>2025-03-19 21:44:25 +0300
commit1794d7ab34d2221ac7eb921b171e75b856e10561 (patch)
tree1875f98906df270c9ca0bb7992cf2c5ab5821197
parent90c80211559ee8e9b6104cb3cb519a6ac3155a2a (diff)
downloadlinux-1794d7ab34d2221ac7eb921b171e75b856e10561.tar.xz
wifi: mt76: mt7996: fix locking in mt7996_mac_sta_rc_work()
The 'continue' statements need to be under spinlock, since the spinlock needs to be held as a loop invariant. Fixes: 0762bdd30279 ("wifi: mt76: mt7996: rework mt7996_mac_sta_rc_work to support MLO") Signed-off-by: Johannes Berg <johannes.berg@intel.com>
-rw-r--r--drivers/net/wireless/mediatek/mt76/mt7996/mac.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mac.c b/drivers/net/wireless/mediatek/mt76/mt7996/mac.c
index a52b4e71b267..d89c06f47997 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7996/mac.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7996/mac.c
@@ -2334,7 +2334,6 @@ void mt7996_mac_sta_rc_work(struct work_struct *work)
changed = msta_link->changed;
msta_link->changed = 0;
- spin_unlock_bh(&dev->mt76.sta_poll_lock);
sta = wcid_to_sta(&msta_link->wcid);
link_id = msta_link->wcid.link_id;
@@ -2354,6 +2353,8 @@ void mt7996_mac_sta_rc_work(struct work_struct *work)
if (!link_conf)
continue;
+ spin_unlock_bh(&dev->mt76.sta_poll_lock);
+
link = (struct mt7996_vif_link *)mlink;
if (changed & (IEEE80211_RC_SUPP_RATES_CHANGED |