diff options
| author | Jens Axboe <axboe@kernel.dk> | 2025-01-13 20:27:54 +0300 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2025-01-13 20:27:54 +0300 |
| commit | 170e086ad3997f816d1f551f178a03a626a130b7 (patch) | |
| tree | a875389a186984860e174a360b2f4befac542ad2 | |
| parent | e494e451611a3de6ae95f99e8339210c157d70fb (diff) | |
| download | linux-170e086ad3997f816d1f551f178a03a626a130b7.tar.xz | |
nvme: fix bogus kzalloc() return check in nvme_init_effects_log()
nvme_init_effects_log() returns failure when kzalloc() is successful,
which is obviously wrong and causes failures to boot. Correct the
check.
Fixes: d4a95adeabc6 ("nvme: Add error path for xa_store in nvme_init_effects")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | drivers/nvme/host/core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 9e7f1bb81973..0d21258e2283 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -3182,7 +3182,7 @@ static int nvme_init_effects_log(struct nvme_ctrl *ctrl, struct nvme_effects_log *effects, *old; effects = kzalloc(sizeof(*effects), GFP_KERNEL); - if (effects) + if (!effects) return -ENOMEM; old = xa_store(&ctrl->cels, csi, effects, GFP_KERNEL); |