diff options
| author | Namjae Jeon <linkinjeon@kernel.org> | 2025-03-22 03:20:19 +0300 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2025-03-28 03:12:00 +0300 |
| commit | 15a9605f8d69dc85005b1a00c31a050b8625e1aa (patch) | |
| tree | 36fd995c8de5af1afea34cbe610ac4836e353064 | |
| parent | 6955bfef8f2b5b2f4e35577b708967bd986d3aa3 (diff) | |
| download | linux-15a9605f8d69dc85005b1a00c31a050b8625e1aa.tar.xz | |
ksmbd: fix use-after-free in ksmbd_sessions_deregister()
In multichannel mode, UAF issue can occur in session_deregister
when the second channel sets up a session through the connection of
the first channel. session that is freed through the global session
table can be accessed again through ->sessions of connection.
Cc: stable@vger.kernel.org
Reported-by: Norbert Szetei <norbert@doyensec.com>
Tested-by: Norbert Szetei <norbert@doyensec.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
| -rw-r--r-- | fs/smb/server/mgmt/user_session.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/smb/server/mgmt/user_session.c b/fs/smb/server/mgmt/user_session.c index 71c6939dfbf1..1ecca6785ed0 100644 --- a/fs/smb/server/mgmt/user_session.c +++ b/fs/smb/server/mgmt/user_session.c @@ -230,6 +230,9 @@ void ksmbd_sessions_deregister(struct ksmbd_conn *conn) if (!ksmbd_chann_del(conn, sess) && xa_empty(&sess->ksmbd_chann_list)) { hash_del(&sess->hlist); + down_write(&conn->session_lock); + xa_erase(&conn->sessions, sess->id); + up_write(&conn->session_lock); ksmbd_session_destroy(sess); } } |