diff options
| author | Zhen Lei <thunder.leizhen@huawei.com> | 2021-05-08 05:47:37 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-06-10 13:43:50 +0300 |
| commit | 14e501aabe1ced97c50a9fb2f70ec55dd6c46bb7 (patch) | |
| tree | 666fc60e358a7dfe0a735bd9f3f3bffbd57ea052 | |
| parent | 5fb5c7ec60a238dcb0d926df8654fc21da80e161 (diff) | |
| download | linux-14e501aabe1ced97c50a9fb2f70ec55dd6c46bb7.tar.xz | |
HID: pidff: fix error return code in hid_pidff_init()
[ Upstream commit 3dd653c077efda8152f4dd395359617d577a54cd ]
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: 224ee88fe395 ("Input: add force feedback driver for PID devices")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/hid/usbhid/hid-pidff.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index 08174d341f4a..bc75f1efa0f4 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -1304,6 +1304,7 @@ int hid_pidff_init(struct hid_device *hid) if (pidff->pool[PID_DEVICE_MANAGED_POOL].value && pidff->pool[PID_DEVICE_MANAGED_POOL].value[0] == 0) { + error = -EPERM; hid_notice(hid, "device does not support device managed pool\n"); goto fail; |