diff options
| author | Matthias May <matthias.may@westermo.com> | 2022-08-05 22:19:03 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-08-25 12:45:21 +0300 |
| commit | 13904ed832a912fa8b4f69ab9cbffcbb035a0bc3 (patch) | |
| tree | 81bb083137bcde53ea7e6f9a20b5287ee8073a50 | |
| parent | 29fea5c51a5cf7d7babd7a81fd17f64359d6a06d (diff) | |
| download | linux-13904ed832a912fa8b4f69ab9cbffcbb035a0bc3.tar.xz | |
geneve: do not use RT_TOS for IPv6 flowlabel
commit ca2bb69514a8bc7f83914122f0d596371352416c upstream.
According to Guillaume Nault RT_TOS should never be used for IPv6.
Quote:
RT_TOS() is an old macro used to interprete IPv4 TOS as described in
the obsolete RFC 1349. It's conceptually wrong to use it even in IPv4
code, although, given the current state of the code, most of the
existing calls have no consequence.
But using RT_TOS() in IPv6 code is always a bug: IPv6 never had a "TOS"
field to be interpreted the RFC 1349 way. There's no historical
compatibility to worry about.
Fixes: 3a56f86f1be6 ("geneve: handle ipv6 priority like ipv4 tos")
Acked-by: Guillaume Nault <gnault@redhat.com>
Signed-off-by: Matthias May <matthias.may@westermo.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/net/geneve.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index 018d365f9deb..273806abd60f 100644 --- a/drivers/net/geneve.c +++ b/drivers/net/geneve.c @@ -876,8 +876,7 @@ static struct dst_entry *geneve_get_v6_dst(struct sk_buff *skb, use_cache = false; } - fl6->flowlabel = ip6_make_flowinfo(RT_TOS(prio), - info->key.label); + fl6->flowlabel = ip6_make_flowinfo(prio, info->key.label); dst_cache = (struct dst_cache *)&info->dst_cache; if (use_cache) { dst = dst_cache_get_ip6(dst_cache, &fl6->saddr); |