summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZhang Yi <yi.zhang@huawei.com>2025-03-19 05:35:57 +0300
committerTheodore Ts'o <tytso@mit.edu>2025-03-21 08:33:11 +0300
commit129245cfbd6d79c6d603f357f428010ccc0f0ee7 (patch)
treeedfa1406e74b278bca06bbe04420dc63ddf97ce4
parent896b02d0b9e7deb4a4eb365e13dd912b49916519 (diff)
downloadlinux-129245cfbd6d79c6d603f357f428010ccc0f0ee7.tar.xz
ext4: correct the error handle in ext4_fallocate()
The error out label of file_modified() should be out_inode_lock in ext4_fallocate(). Fixes: 2890e5e0f49e ("ext4: move out common parts into ext4_fallocate()") Reported-by: Baokun Li <libaokun1@huawei.com> Signed-off-by: Zhang Yi <yi.zhang@huawei.com> Reviewed-by: Baokun Li <libaokun1@huawei.com> Link: https://patch.msgid.link/20250319023557.2785018-1-yi.zhang@huaweicloud.com Signed-off-by: Theodore Ts'o <tytso@mit.edu>
-rw-r--r--fs/ext4/extents.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 1639f75b54df..c616a16a9f36 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -4744,7 +4744,7 @@ long ext4_fallocate(struct file *file, int mode, loff_t offset, loff_t len)
ret = file_modified(file);
if (ret)
- return ret;
+ goto out_inode_lock;
if ((mode & FALLOC_FL_MODE_MASK) == FALLOC_FL_ALLOCATE_RANGE) {
ret = ext4_do_fallocate(file, offset, len, mode);