summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKangjie Lu <kjlu@umn.edu>2018-12-26 09:09:04 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-12-05 17:34:59 +0300
commit10a0e00c095fcfd6b6bc7305341f20519d6b882a (patch)
treebb0100c937abbb2db39923201a06d997ae26723e
parent57b2d68786a843a70bb410a9f38f6671c485d38b (diff)
downloadlinux-10a0e00c095fcfd6b6bc7305341f20519d6b882a.tar.xz
tipc: fix a missing check of genlmsg_put
[ Upstream commit 46273cf7e009231d2b6bc10a926e82b8928a9fb2 ] genlmsg_put could fail. The fix inserts a check of its return value, and if it fails, returns -EMSGSIZE. Signed-off-by: Kangjie Lu <kjlu@umn.edu> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--net/tipc/netlink_compat.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c
index 63a913b23873..454ed8ea194c 100644
--- a/net/tipc/netlink_compat.c
+++ b/net/tipc/netlink_compat.c
@@ -974,6 +974,8 @@ static int tipc_nl_compat_publ_dump(struct tipc_nl_compat_msg *msg, u32 sock)
hdr = genlmsg_put(args, 0, 0, &tipc_genl_family, NLM_F_MULTI,
TIPC_NL_PUBL_GET);
+ if (!hdr)
+ return -EMSGSIZE;
nest = nla_nest_start(args, TIPC_NLA_SOCK);
if (!nest) {