diff options
| author | Milos Nikic <nikic.milos@gmail.com> | 2026-02-07 04:06:17 +0300 |
|---|---|---|
| committer | Jan Kara <jack@suse.cz> | 2026-02-27 14:15:26 +0300 |
| commit | 0cf9c58bf654d0f27abe18005281dbf9890de401 (patch) | |
| tree | 4044f43c9fa546f168266f1c5f7c961eaf43c0df | |
| parent | 6d942c874f6fc8cea801981b6f2cfd9829a641d4 (diff) | |
| download | linux-0cf9c58bf654d0f27abe18005281dbf9890de401.tar.xz | |
ext2: replace BUG_ON with WARN_ON_ONCE in ext2_get_blocks
If ext2_get_blocks() is called with maxblocks == 0, it currently triggers
a BUG_ON(), causing a kernel panic.
While this condition implies a logic error in the caller, a filesystem
should not crash the system due to invalid arguments.
Replace the BUG_ON() with a WARN_ON_ONCE() to provide a stack trace for
debugging, and return -EINVAL to handle the error gracefully.
Signed-off-by: Milos Nikic <nikic.milos@gmail.com>
Link: https://patch.msgid.link/20260207010617.216675-1-nikic.milos@gmail.com
Signed-off-by: Jan Kara <jack@suse.cz>
| -rw-r--r-- | fs/ext2/inode.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c index dbfe9098a124..18bf1a91dbc2 100644 --- a/fs/ext2/inode.c +++ b/fs/ext2/inode.c @@ -638,7 +638,8 @@ static int ext2_get_blocks(struct inode *inode, int count = 0; ext2_fsblk_t first_block = 0; - BUG_ON(maxblocks == 0); + if (WARN_ON_ONCE(maxblocks == 0)) + return -EINVAL; depth = ext2_block_to_path(inode,iblock,offsets,&blocks_to_boundary); |