summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIan Abbott <abbotti@mev.co.uk>2026-01-30 19:48:05 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2026-04-02 16:49:40 +0300
commit0ca9f8150ce5a41a3b4bb65f043f0335e7ef67b5 (patch)
treeb8fa345cdcc938eef8202f85ace34dc6c2762bc5
parentddd5b28744322f9434ab71661a1280f5069983fd (diff)
downloadlinux-0ca9f8150ce5a41a3b4bb65f043f0335e7ef67b5.tar.xz
comedi: pcmad: Add sanity checks for I/O base address
The "pcmad" driver uses an admin-supplied configuration option (`it->options[0]`) to configure the I/O port base address of a PCM-A/D-12 or PCM-A/D-16 board. It currently allows any base address to be configured but the hardware only supports base addresses (configured by on-board jumpers) in the range 0 to 0x3FC on 4-byte boundaries. Add a sanity check to ensure the device is not configured at an unsupported base address. Signed-off-by: Ian Abbott <abbotti@mev.co.uk> Link: https://patch.msgid.link/20260130170416.49994-41-abbotti@mev.co.uk Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/comedi/drivers/pcmad.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/comedi/drivers/pcmad.c b/drivers/comedi/drivers/pcmad.c
index 976eda43881b..fd26b1eed1db 100644
--- a/drivers/comedi/drivers/pcmad.c
+++ b/drivers/comedi/drivers/pcmad.c
@@ -106,7 +106,8 @@ static int pcmad_attach(struct comedi_device *dev, struct comedi_devconfig *it)
struct comedi_subdevice *s;
int ret;
- ret = comedi_request_region(dev, it->options[0], 0x04);
+ ret = comedi_check_request_region(dev, it->options[0], 0x04,
+ 0, 0x3ff, 4);
if (ret)
return ret;