diff options
| author | Bart Van Assche <bvanassche@acm.org> | 2026-02-24 01:00:14 +0300 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2026-02-24 18:31:35 +0300 |
| commit | 07ed4f05bbfd2bc014974dcc4297fd3aa1cb88c0 (patch) | |
| tree | 2802b760d57a62db868f59af7568b1db21949429 | |
| parent | e710b2283725f0db9e5b99c2483df3f4a7feadbd (diff) | |
| download | linux-07ed4f05bbfd2bc014974dcc4297fd3aa1cb88c0.tar.xz | |
hwmon: (it87) Check the it87_lock() return value
Return early in it87_resume() if it87_lock() fails instead of ignoring the
return value of that function. This patch suppresses a Clang thread-safety
warning.
Cc: Frank Crawford <frank@crawford.emu.id.au>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Jean Delvare <jdelvare@suse.com>
Cc: linux-hwmon@vger.kernel.org
Fixes: 376e1a937b30 ("hwmon: (it87) Add calls to smbus_enable/smbus_disable as required")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20260223220102.2158611-15-bart.vanassche@linux.dev
[groeck: Declare 'ret' at the beginning of it87_resume()]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
| -rw-r--r-- | drivers/hwmon/it87.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c index e233aafa8856..5cfb98a0512f 100644 --- a/drivers/hwmon/it87.c +++ b/drivers/hwmon/it87.c @@ -3590,10 +3590,13 @@ static int it87_resume(struct device *dev) { struct platform_device *pdev = to_platform_device(dev); struct it87_data *data = dev_get_drvdata(dev); + int err; it87_resume_sio(pdev); - it87_lock(data); + err = it87_lock(data); + if (err) + return err; it87_check_pwm(dev); it87_check_limit_regs(data); |