summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohan Hovold <johan@kernel.org>2026-05-11 18:04:04 +0300
committerMark Brown <broonie@kernel.org>2026-05-18 12:19:48 +0300
commit06ba67d9d47929652f66b7c3eeda5293f48a4545 (patch)
tree129932fa40914113f95521ac728a637d9cb93afc
parent0a290bb1ff0b11998db2b36c8ebcca4913ccacb7 (diff)
downloadlinux-06ba67d9d47929652f66b7c3eeda5293f48a4545.tar.xz
spi: lp8841-rtc: switch to managed controller allocation
Switch to device managed controller allocation for consistency and to simplify error handling. Signed-off-by: Johan Hovold <johan@kernel.org> Link: https://patch.msgid.link/20260511150408.796155-9-johan@kernel.org Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r--drivers/spi/spi-lp8841-rtc.c14
1 files changed, 4 insertions, 10 deletions
diff --git a/drivers/spi/spi-lp8841-rtc.c b/drivers/spi/spi-lp8841-rtc.c
index e466866d5e80..355d9df4d1be 100644
--- a/drivers/spi/spi-lp8841-rtc.c
+++ b/drivers/spi/spi-lp8841-rtc.c
@@ -185,7 +185,7 @@ spi_lp8841_rtc_probe(struct platform_device *pdev)
struct spi_controller *host;
struct spi_lp8841_rtc *data;
- host = spi_alloc_host(&pdev->dev, sizeof(*data));
+ host = devm_spi_alloc_host(&pdev->dev, sizeof(*data));
if (!host)
return -ENOMEM;
platform_set_drvdata(pdev, host);
@@ -208,23 +208,17 @@ spi_lp8841_rtc_probe(struct platform_device *pdev)
ret = PTR_ERR_OR_ZERO(data->iomem);
if (ret) {
dev_err(&pdev->dev, "failed to get IO address\n");
- goto err_put_host;
+ return ret;
}
/* register with the SPI framework */
ret = devm_spi_register_controller(&pdev->dev, host);
if (ret) {
dev_err(&pdev->dev, "cannot register spi host\n");
- goto err_put_host;
+ return ret;
}
- return ret;
-
-
-err_put_host:
- spi_controller_put(host);
-
- return ret;
+ return 0;
}
MODULE_ALIAS("platform:" DRIVER_NAME);