summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJunfeng Guo <junfeng.guo@intel.com>2023-07-06 07:41:28 +0300
committerJakub Kicinski <kuba@kernel.org>2023-07-07 05:14:24 +0300
commit0503efeadbf6bb8bf24397613a73b67e665eac5f (patch)
tree45b951b8b56b6bb9bd6c4c5f1a4dca9a6b0d801c
parent41b9eff0ce2257958531e7cd38068845da38ac53 (diff)
downloadlinux-0503efeadbf6bb8bf24397613a73b67e665eac5f.tar.xz
gve: Set default duplex configuration to full
Current duplex mode was unset in the driver, resulting in the default parameter being set to 0, which corresponds to half duplex. It might mislead users to have incorrect expectation about the driver's transmission capabilities. Set the default duplex configuration to full, as the driver runs in full duplex mode at this point. Fixes: 7e074d5a76ca ("gve: Enable Link Speed Reporting in the driver.") Signed-off-by: Junfeng Guo <junfeng.guo@intel.com> Reviewed-by: Leon Romanovsky <leonro@nvidia.com> Message-ID: <20230706044128.2726747-1-junfeng.guo@intel.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
-rw-r--r--drivers/net/ethernet/google/gve/gve_ethtool.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/net/ethernet/google/gve/gve_ethtool.c b/drivers/net/ethernet/google/gve/gve_ethtool.c
index cfd4b8d284d1..50162ec9424d 100644
--- a/drivers/net/ethernet/google/gve/gve_ethtool.c
+++ b/drivers/net/ethernet/google/gve/gve_ethtool.c
@@ -590,6 +590,9 @@ static int gve_get_link_ksettings(struct net_device *netdev,
err = gve_adminq_report_link_speed(priv);
cmd->base.speed = priv->link_speed;
+
+ cmd->base.duplex = DUPLEX_FULL;
+
return err;
}