diff options
| author | Chuck Lever <chuck.lever@oracle.com> | 2026-06-01 20:54:12 +0300 |
|---|---|---|
| committer | Anna Schumaker <anna.schumaker@hammerspace.com> | 2026-06-08 17:21:56 +0300 |
| commit | 04dd9cdbe59a9056b4cc8de07e1585db77661cbc (patch) | |
| tree | 6e627f29ebcab6bcb679d32cb4c5582a8a2d50c3 | |
| parent | 797943e8bd1ffcc63bfe79d24faad9a77054ec40 (diff) | |
| download | linux-04dd9cdbe59a9056b4cc8de07e1585db77661cbc.tar.xz | |
xprtrdma: Fix I3 invariant comment in rpcrdma_complete_rqst
frwr_unmap_sync() and frwr_unmap_async() drain rl_registered via
rpcrdma_mr_pop() before posting invalidation Work Requests to
hardware. The WARN_ON_ONCE verifies that the list-drain step
has occurred, not that hardware unmapping has completed.
Reword the comment to match what the assertion actually checks.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Anna Schumaker <anna.schumaker@hammerspace.com>
| -rw-r--r-- | net/sunrpc/xprtrdma/rpc_rdma.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/sunrpc/xprtrdma/rpc_rdma.c b/net/sunrpc/xprtrdma/rpc_rdma.c index 626cadec4555..f115baba6d56 100644 --- a/net/sunrpc/xprtrdma/rpc_rdma.c +++ b/net/sunrpc/xprtrdma/rpc_rdma.c @@ -1336,8 +1336,8 @@ void rpcrdma_complete_rqst(struct rpcrdma_rep *rep) struct rpc_rqst *rqst = rep->rr_rqst; int status; - /* I3: every registered MR has been invalidated and - * ib_dma_unmap_sg()'d before complete_rqst runs. + /* I3: rl_registered has been drained by frwr_unmap before + * complete_rqst runs. */ WARN_ON_ONCE(!list_empty(&rpcr_to_rdmar(rqst)->rl_registered)); |