summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAl Viro <viro@zeniv.linux.org.uk>2019-10-25 07:03:11 +0300
committerAl Viro <viro@zeniv.linux.org.uk>2019-10-25 07:03:11 +0300
commit03ad0d703df75c43f78bd72e16124b5b94a95188 (patch)
treed3915a4d9c614df558bbdd073544786e09595b5e
parent97eba80fcca754856d09e048f469db22773bec68 (diff)
downloadlinux-03ad0d703df75c43f78bd72e16124b5b94a95188.tar.xz
autofs: fix a leak in autofs_expire_indirect()
if the second call of should_expire() in there ends up grabbing and returning a new reference to dentry, we need to drop it before continuing. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
-rw-r--r--fs/autofs/expire.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/fs/autofs/expire.c b/fs/autofs/expire.c
index 2866fabf497f..91f5787dae7c 100644
--- a/fs/autofs/expire.c
+++ b/fs/autofs/expire.c
@@ -459,9 +459,10 @@ static struct dentry *autofs_expire_indirect(struct super_block *sb,
*/
how &= ~AUTOFS_EXP_LEAVES;
found = should_expire(expired, mnt, timeout, how);
- if (!found || found != expired)
- /* Something has changed, continue */
+ if (found != expired) { // something has changed, continue
+ dput(found);
goto next;
+ }
if (expired != dentry)
dput(dentry);