diff options
| author | Larry Finger <Larry.Finger@lwfinger.net> | 2019-08-12 22:27:41 +0300 |
|---|---|---|
| committer | Kalle Valo <kvalo@codeaurora.org> | 2019-09-03 16:28:13 +0300 |
| commit | 01bb31de526265e51e21e3efcdcbbe7e6906b051 (patch) | |
| tree | d5ec3937d0d3b9933ff433ea44c0df92a4dd849e | |
| parent | b6326fc025aa998daa62672731ecfdcc22f43771 (diff) | |
| download | linux-01bb31de526265e51e21e3efcdcbbe7e6906b051.tar.xz | |
rtlwifi: rtl8192cu: Fix value set in descriptor
In the process of converting the bit manipulation macros were converted
to use GENMASK(), the compiler reported a value too big for the field.
The offending statement was trying to write 0x100 into a 5-bit field.
An accompaning comment says to set bit 3, thus the code is changed
appropriately.
This error has been in the driver since its initial submission.
Fixes: 29d00a3e46bb ("rtlwifi: rtl8192cu: Add routine trx")
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
| -rw-r--r-- | drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c index 0020adc004a5..9b5c7ec6b6f7 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c @@ -611,7 +611,7 @@ void rtl92cu_fill_fake_txdesc(struct ieee80211_hw *hw, u8 *pdesc, SET_TX_DESC_NAV_USE_HDR(pdesc, 1); } else { SET_TX_DESC_HWSEQ_EN(pdesc, 1); /* Hw set sequence number */ - SET_TX_DESC_PKT_ID(pdesc, 0x100); /* set bit3 to 1. */ + SET_TX_DESC_PKT_ID(pdesc, BIT(3)); /* set bit3 to 1. */ } SET_TX_DESC_USE_RATE(pdesc, 1); /* use data rate which is set by Sw */ SET_TX_DESC_OWN(pdesc, 1); |