guard unterminated AI in ExpandedProductResultParser (#2088)

1 files changed, 10 insertions, 0 deletions

diff --git a/core/src/test/java/com/google/zxing/client/result/ExpandedProductParsedResultTestCase.java b/core/src/test/java/com/google/zxing/client/result/ExpandedProductParsedResultTestCase.java
index 861e6636f..7f83999d0 100644
--- a/core/src/test/java/com/google/zxing/client/result/ExpandedProductParsedResultTestCase.java
+++ b/core/src/test/java/com/google/zxing/client/result/ExpandedProductParsedResultTestCase.java
@@ -63,4 +63,14 @@ public final class ExpandedProductParsedResultTestCase extends Assert {
     assertEquals("445", o.getPriceCurrency());
     assertEquals(uncommonAIs, o.getUncommonAIs());
   }
+
+  @Test
+  public void testUnterminatedAI() {
+    // an AI that is not closed by ')' must not match, rather than read past the end of the text
+    ExpandedProductResultParser parser = new ExpandedProductResultParser();
+    assertNull(parser.parse(new Result("(99", null, null, BarcodeFormat.RSS_EXPANDED)));
+    assertNull(parser.parse(new Result("(", null, null, BarcodeFormat.RSS_EXPANDED)));
+    // a valid prefix followed by a truncated final AI must parse without throwing
+    assertNotNull(parser.parse(new Result("(01)66546(13)001205(3932", null, null, BarcodeFormat.RSS_EXPANDED)));
+  }
 }