ShellPkg/Shell: Terminate and separate the ShellOpt command line

CreatePopulateInstallShellParametersProtocol() combined image load options
and ShellOpt without reserving a NUL terminator. Neither input must carry
one, so ParseCommandLineToArgs() could read beyond the allocation. The
load options also overwrote ShellOpt when both inputs were present.

Read ShellOpt into a separately terminated buffer, validate its CHAR16
size, normalize its effective length, and propagate read failures. Reserve
space for a separator and terminator in the combined buffer.

Preserve the image name at Argv[0] and insert ShellOpt immediately after
it, before the rest of the load options. Appending ShellOpt at the end
would pass shell options as arguments to a script or application named in
the load options. Use the parser's argument-boundary rules so quoted
image paths retain their meaning.

Fixes: https://github.com/tianocore/edk2/issues/10549
Signed-off-by: Jin Kang <112378607+JinKang021004@users.noreply.github.com>

0 files changed, 0 insertions, 0 deletions