diff options
| author | Aaron Pop <aaronpop@microsoft.com> | 2026-08-10 22:08:52 +0300 |
|---|---|---|
| committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | 2026-08-11 04:22:08 +0300 |
| commit | 816b35fe52388564498c5885ced765ea2d5394a5 (patch) | |
| tree | fbe264290b060836aea9789bc4780f91d86ca9fe /MdeModulePkg/Library | |
| parent | c5aa7e7d94c0e6b3c0202e15dbf7a5c92dd6a01d (diff) | |
| download | edk2-816b35fe52388564498c5885ced765ea2d5394a5.tar.xz | |
MdeModulePkg/UefiHiiLib: Fix regression from 12828
12828 introduced an ASSERT in HiiGetBrowserData() that fires when
InternalHiiBrowserCallback() returns NULL. This is a valid return
value indicating the browser has no data for the requested variable,
and callers already handle this by checking the FALSE return value.
The ASSERT is incorrect because it triggers on a non-error path,
causing a crash when the browser callback legitimately returns no data.
Remove the unnecessary ASSERT while keeping the existing FALSE return
so callers continue to handle this case gracefully.
Cc: Qihang Gao <gaoqihang@loongson.cn>
Signed-off-by: Aaron Pop <aaronpop@microsoft.com>
Diffstat (limited to 'MdeModulePkg/Library')
| -rw-r--r-- | MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c index 476b69eec3..18796aba72 100644 --- a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c +++ b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c @@ -2927,7 +2927,6 @@ HiiGetBrowserData ( //
ResultsData = InternalHiiBrowserCallback (VariableGuid, VariableName, NULL);
if (ResultsData == NULL) {
- ASSERT (ResultsData != NULL);
return FALSE;
}
|