diff options
| author | Nick Betteridge <lists.nick.betteridge@gmail.com> | 2026-10-19 11:14:58 +0300 |
|---|---|---|
| committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | 2026-10-21 16:45:44 +0300 |
| commit | 48f7e470ebbc235ddec904311d42ced562d304ae (patch) | |
| tree | be6de5bb98e85124cd3e6a8551a5e4060cb56d54 /MdeModulePkg/Library/PiDxeS3BootScriptLib/BootScriptExecute.c | |
| parent | 062dd08efded1cf905e06da13732acf77bc1a0f8 (diff) | |
| download | edk2-48f7e470ebbc235ddec904311d42ced562d304ae.tar.xz | |
OvmfPkg/RiscVVirt/PlatformPei: Do not hide side effects in ASSERTs
FindInstallPeiMemory() calls PeiServicesInstallPeiMemory() and
SetupTPMResources() calls PcdSet64S (PcdTpmBaseAddress, ...) only as
the argument of ASSERT_EFI_ERROR. With MDEPKG_NDEBUG (RELEASE builds)
the macro expands to nothing, so neither call is made:
- with RISCVVIRT_PEI_BOOTING, PEI memory is never installed and PeiCore
never leaves temporary RAM (silent hang, "DXE IPL PPI not found" in a
DEBUG build with asserts disabled);
- with TPM2_ENABLE, PcdTpmBaseAddress stays 0 and Tcg2Pei faults on
MmioRead8 (0).
Make both calls unconditionally and assert on the returned status.
Signed-off-by: Nick Betteridge <lists.nick.betteridge@gmail.com>
Diffstat (limited to 'MdeModulePkg/Library/PiDxeS3BootScriptLib/BootScriptExecute.c')
0 files changed, 0 insertions, 0 deletions
