BaseTools: AutoGen: Optimize tuple creation using tuple() for PcdDbBuffer

Replace manual loop-based tuple construction with the built-in tuple()
function when converting PcdDbBuffer to a tuple. This change
significantly improves performance—approximately three times
faster—resulting in substantial build time savings in large
environments.

Previously, the code iterated over each byte in PcdDbBuffer, unpacking
and appending it to a tuple. The new approach leverages
tuple(PcdDbBuffer) to achieve the same result more efficiently. The
generated tuple remains identical to the original implementation.

TEST=The generated tuple is the same than with to original code

Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com>

1 files changed, 2 insertions, 6 deletions

diff --git a/BaseTools/Source/Python/AutoGen/GenPcdDb.py b/BaseTools/Source/Python/AutoGen/GenPcdDb.py
index 28df647bfe..d2cac62d1c 100644
--- a/BaseTools/Source/Python/AutoGen/GenPcdDb.py
+++ b/BaseTools/Source/Python/AutoGen/GenPcdDb.py
@@ -942,9 +942,7 @@ def NewCreatePcdDatabasePhaseSpecificAutoGen(Platform, Phase):
     if DynamicPcdSet_Sku:

         for skuname, skuid in DynamicPcdSet_Sku:

             AdditionalAutoGenH, AdditionalAutoGenC, PcdDbBuffer, VarCheckTab = CreatePcdDatabasePhaseSpecificAutoGen (Platform, DynamicPcdSet_Sku[(skuname, skuid)], Phase)

-            final_data = ()

-            for item in range(len(PcdDbBuffer)):

-                final_data += unpack("B", PcdDbBuffer[item:item+1])

+            final_data = tuple(PcdDbBuffer)

             PcdDBData[(skuname, skuid)] = (PcdDbBuffer, final_data)

             PcdDriverAutoGenData[(skuname, skuid)] = (AdditionalAutoGenH, AdditionalAutoGenC)

             VarCheckTableData[(skuname, skuid)] = VarCheckTab

@@ -955,9 +953,7 @@ def NewCreatePcdDatabasePhaseSpecificAutoGen(Platform, Phase):
         AdditionalAutoGenH, AdditionalAutoGenC =  CreateAutoGen(PcdDriverAutoGenData)

     else:

         AdditionalAutoGenH, AdditionalAutoGenC, PcdDbBuffer, VarCheckTab = CreatePcdDatabasePhaseSpecificAutoGen (Platform, {}, Phase)

-        final_data = ()

-        for item in range(len(PcdDbBuffer)):

-            final_data += unpack("B", PcdDbBuffer[item:item + 1])

+        final_data = tuple(PcdDbBuffer)

         PcdDBData[(TAB_DEFAULT, "0")] = (PcdDbBuffer, final_data)

 

     return AdditionalAutoGenH, AdditionalAutoGenC, CreatePcdDataBase(PcdDBData)