diff options
author | Ruiyu Ni <ruiyu.ni@intel.com> | 2017-10-09 10:12:36 +0300 |
---|---|---|
committer | Ruiyu Ni <ruiyu.ni@intel.com> | 2017-10-10 08:23:10 +0300 |
commit | 0a274516ff7efdd5a1ea8193423850ff02025e90 (patch) | |
tree | 64cb6aba62fe1565d2df66c06ff03e7d3141c2a9 /BaseTools/Source/Python/build/BuildReport.py | |
parent | fbe538450fb5327110f3b01d038e356e590dd93a (diff) | |
download | edk2-0a274516ff7efdd5a1ea8193423850ff02025e90.tar.xz |
MdeModulePkg/S3SaveState: Extract arguments in correct order
EFI_BOOT_SCRIPT_WRITE() interface is a var-arg interface.
Spec defines the order of parameters for
EFI_BOOT_SCRIPT_PCI_CONFIG2_WRITE_OPCODE as below:
typedef
EFI_STATUS
(EFIAPI *EFI_BOOT_SCRIPT_WRITE) (
IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This,
IN UINT16 OpCode,
IN EFI_BOOT_SCRIPT_WIDTH Width,
IN UINT16 Segment,
IN UINT64 Address,
IN UINTN Count,
IN VOID *Buffer
);
But implementation assumes Segment is in the very end, after Buffer.
Similar spec/implementation gaps are also found for
EFI_BOOT_SCRIPT_PCI_CONFIG2_READ_WRITE_OPCODE.
The patch fixes the implementation to extract the arguments in
correct order.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
Diffstat (limited to 'BaseTools/Source/Python/build/BuildReport.py')
0 files changed, 0 insertions, 0 deletions