NetworkPkg/IScsiDxe: Fix AttemptName cleared on loading defaults

Root Cause:
The AttemptName string field in IScsiConfigVfr.vfr had
default = STRING_TOKEN(STR_NULL), which resolves to an empty
string. When optimized defaults are loaded (F3), the form browser
resets every field to its defined default, wiping out the actual
attempt names (e.g. Attempt 1, Attempt 2) and leaving the field
blank.

Fix:
Add the INTERACTIVE flag to the AttemptName string field in VFR.
This tells the form browser to invoke the driver callback when
loading defaults instead of applying the hardcoded empty string.

Introduce a helper function IScsiGetAttemptNameDefault() that reads
the stored attempt name from mCallbackInfo->Current->AttemptName,
registers it as a HII string, and returns it as the default value.
The helper also validates that the question type is
EFI_IFR_TYPE_STRING before accessing Value->string.

In IScsiFormCallback, handle EFI_BROWSER_ACTION_DEFAULT_STANDARD,
EFI_BROWSER_ACTION_DEFAULT_MANUFACTURING, and
EFI_BROWSER_ACTION_DEFAULT_SAFE for KEY_ATTEMPT_NAME by delegating
to the helper. This ensures loading any class of defaults always
restores the correct attempt name for whichever attempt is open.

Cc: Saloni Kasbekar <saloni.kasbekar@intel.com>
Cc: Zachary Clark-williams <zachary.clark-williams@intel.com>

Signed-off-by: Abuthahir M <abuthahirm@ami.com>

0 files changed, 0 insertions, 0 deletions