BaseTools: drop GeneralCheckNonAscii() from ECC

The GeneralCheckNonAscii() function is a sledgehammer rejecting any file
containing any character outside of the 7-bit ASCII encoding space, as
well as the DEL character (which seems unrelated).

This conflicts with basic stuff like correctly spelling certain proper
nouns in comments (like copyright statements), or string literals (for
example in multi-language driver binding ComponentNames).

So rip it out, to be replaced by more fine-grained checks to be added as
identified and needed.

Signed-off-by: Leif Lindholm <quic_llindhol@quicinc.com>

1 files changed, 0 insertions, 3 deletions

diff --git a/BaseTools/Source/Python/Ecc/Configuration.py b/BaseTools/Source/Python/Ecc/Configuration.py
index ec49e0d0aa..d4aab1d131 100644
--- a/BaseTools/Source/Python/Ecc/Configuration.py
+++ b/BaseTools/Source/Python/Ecc/Configuration.py
@@ -59,7 +59,6 @@ _ConfigFileToInternalTranslation = {
     "GeneralCheckNoProgma":"GeneralCheckNoProgma",

     "GeneralCheckNoTab":"GeneralCheckNoTab",

     "GeneralCheckNo_Asm":"GeneralCheckNo_Asm",

-    "GeneralCheckNonAscii":"GeneralCheckNonAscii",

     "GeneralCheckTabWidth":"GeneralCheckTabWidth",

     "GeneralCheckTrailingWhiteSpaceLine":"GeneralCheckTrailingWhiteSpaceLine",

     "GeneralCheckUni":"GeneralCheckUni",

@@ -179,8 +178,6 @@ class Configuration(object):
         self.GeneralCheckCarriageReturn = 1

         # Check whether the file exists

         self.GeneralCheckFileExistence = 1

-        # Check whether file has non ASCII char

-        self.GeneralCheckNonAscii = 1

         # Check whether UNI file is valid

         self.GeneralCheckUni = 1

         # Check Only use CRLF (Carriage Return Line Feed) line endings.