| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
The ESLint 9 flat config in eslint.config.js silently disabled almost
every rule the project relied on. Both npm run lint and the VS Code
ESLint extension reported only a handful of TypeScript plugin errors,
so contributors stopped seeing formatting warnings and common semantic
mistakes in the editor. This matches the recent Discord report that the
ESLint extension was no longer flagging errors on master.
The @eslint/js recommended rules were never spread into the base
config, so core rules such as no-unused-vars, no-redeclare and no-undef
were off. eslint-plugin-prettier was listed in package.json but never
registered, so prettier/prettier never ran and formatting issues
produced zero diagnostics. TypeScript also had no parser, no
@typescript-eslint rules, and no eslint-recommended compat layer.
This change:
- Enables @eslint/js recommended rules in the base config and turns on
no-duplicate-imports.
- Registers eslint-plugin-prettier so prettier/prettier runs after
eslint-config-prettier. Options still come from .prettierrc.yaml,
which now adds *.ts/*.tsx to the 2-space override so TypeScript
keeps its 2-space indent (CI Prettier does not format TypeScript).
- Wires the @typescript-eslint parser into .ts files and Vue
<script lang="ts"> blocks, applies @typescript-eslint recommended
plus flat/eslint-recommended scoped to TS files, and sets
@typescript-eslint/no-unused-vars to error with ^_ ignore patterns.
- Awaits the config (export default await createConfig()) so the
export is a plain array; a Promise makes some ESLint extension
versions treat the config as empty.
- Fixes the violations the new rules surface: an any cast, two Object
annotations, and duplicated vue imports.
- Removes .eslintrc.js, which is dead under ESLint 9.
After the fix, npm run lint passes. Remaining debt in test and config
files outside src/ is left to a follow-up to keep this change small.
Change-Id: Ie0b0b26662e89d36ec5d488aca2dc365661243b7
Signed-off-by: Aravinth Sri Krishna Raja Raghavan <aravinths@ami.com>
|
|
This change migrates the Reboot BMC page from Vuex to TanStack Query
and Composition API
Key changes:
1. Redfish types (src/api/types/redfish.ts):
- Adds Manager interface with LastResetTime and Actions fields,
typed in PascalCase to match the Redfish schema
2. BMC reboot composable
(src/components/Composables/useRebootBmc.ts):
- Replaces Vuex controls/getLastBmcRebootTime and controls/rebootBmc
with a Composition API composable
- Uses useRedfishRoot() to resolve the Managers collection URI from
ServiceRoot; fetches the first member (the BMC Manager) in queryFn
- Configures staleTime: Infinity and gcTime: Infinity because
LastResetTime only changes on a reboot; onSuccess invalidation
handles the one real change event, avoiding unnecessary refetches
- mutationFn is pure (no i18n strings, no toast calls); view owns
all user-facing messages via try/catch
- onSuccess calls invalidateQueries only (no optimistic update,
which would be immediately overwritten by the refetch)
- resetTarget prefers Actions['#Manager.Reset'].target from the
cached Manager, falls back to the conventional Redfish path
3. View modernization
(src/views/Operations/RebootBmc/RebootBmc.vue):
- Refactors from Options API to <script setup>, using useRebootBmc(),
useLoadingBar(), and useToast() composables
- Loader semantics: isLoading drives the loading bar on first fetch
only; cached data renders instantly on re-navigation with a silent
background refetch (no flicker)
- Reboot button disabled when bmcQuery.isError is true, preventing
mutation dispatch with an unavailable reset target
- Confirm dialog uses eventBus.$emit('confirm:open', ...) directly,
matching the $confirm global property contract without Options API
4. Store cleanup
(src/store/modules/Operations/ControlStore.js):
- Removes lastBmcRebootTime state, getter, and setLastBmcRebootTime
mutation (now owned by bmcQuery in the composable)
- Removes getLastBmcRebootTime and rebootBmc actions (replaced by
useQuery and useMutation in useRebootBmc.ts)
- Removes unused i18n import
- Remaining ControlStore state (isOperationInProgress,
lastPowerOperationTime) and server power actions are unchanged;
they are still used by ServerPowerOperations.vue and Firmware.vue
5. Toast rendering fix (src/components/Composables/useToast.ts,
src/plugins/toast.js):
- Fixes modelValue: false → true for danger/error toasts in both
the Composition API useToast composable and the Options API
ToastPlugin; modelValue: false suppressed toast rendering
entirely in bootstrap-vue-next, making error toasts invisible
app-wide
Tested-by: Manual testing on development server
- Last BMC reboot time loads correctly from Manager.LastResetTime
- Reboot button triggers GracefulRestart POST; success and error
toasts display with localized messages
- Loading bar shows on first page load and during reboot POST;
subsequent visits render cached data instantly
- Read-only user receives the global Unauthorized toast (403
interceptor) followed by the page-level error toast
Change-Id: I5d49527f176041958e48889d6261780fcffdd9df
Signed-off-by: Nikhil Ashoka <a.nikhil@ibm.com>
|
|
Issue:
The sensors page should list all sensors from all hosts.
This is not the case.
The commit adding this issue was 'Implemented Power page with VueQuery
and Composition API'
99099183438d878391f66d3c674fa2cd037a7840
Committed on June 9, 2026 [1]
The commit add to the discoverParentsWithSubResource function the select
query parameter to the parentCollectionPath.
As of today this function is only used in useAllSubResources.
The useAllSubResources function is also only used once, with the
parentCollectionPath='/redfish/v1/Chassis'.
This path get back :
{
"@odata.id": "/redfish/v1/Systems",
"@odata.type": "#ComputerSystemCollection.ComputerSystemCollection",
"Members": [
{
"@odata.id": "/redfish/v1/Systems/system"
}
],
"Members@odata.count": 1,
"Name": "Computer System Collection"
}
If this is filtered with the select='Sensors', then we have nothing.
There is no reason to apply the select filter to the
parentCollectionPath query.
Solution:
This patch remove the filter on the parentCollectionPath query.
Tested:
- all sensors are now visible in the sensors page
[1] https://github.com/openbmc/webui-vue/commit/99099183438d878391f66d3c674fa2cd037a7840
Change-Id: I0a35f9468a9583e4e87b6fd21cd9d81c08fd4fbe
Signed-off-by: Grégoire Layet <gregoire.layet@9elements.com>
|
|
This change switches power control to the EnvironmentMetrics-based
Redfish endpoint, derives minimum and maximum power cap values
dynamically from Redfish data, and updates ControlMode and SetPoint
handling to align with the latest schema.
Key changes:
1. Power control API and Redfish types:
- Removes src/api/services/powerControlService.ts; fetching and
PATCH are handled in the composable using shared Redfish utilities
- Adds EnvironmentMetrics and PowerLimitWatts types in
src/api/types/redfish.ts with proper ControlMode enum
('Automatic' | 'Disabled' | 'Manual' | 'Override')
- Chassis gains an EnvironmentMetrics link
- Composable resolves the Chassis collection via
useRedfishCollection<Chassis>('/redfish/v1/Chassis'), picks the
first chassis with EnvironmentMetrics, and fetches that resource
with useQuery; mutation sends PATCH and invalidates queries to
refetch fresh server state (returns Promise<void>; view owns
user-facing messages)
2. Power control composable
(src/components/Composables/usePowerControl.ts):
- Replaces Vuex PowerControlStore with a Composition API-based
composable
- Uses useRedfishRoot() and useRedfishCollection for cached
ServiceRoot and Chassis; uses TanStack Query to load and cache
EnvironmentMetrics power data
- Configures staleTime (30s freshness window) and refetchInterval
(30s automatic polling when tab visible) for live power
consumption updates
- Note: Only controls the first Chassis with EnvironmentMetrics in
multi-chassis systems (intentional for current use case)
- Forwards AbortSignal to API calls for proper request cancellation
- Reuses shouldRetry function from useAllSubResources
- Derives dynamic min and max power cap values from Redfish
PowerLimitWatts.AllowableMin/Max
- Provides a mutation for submitting updated SetPoint and
ControlMode; omits SetPoint when disabling to avoid sending
invalid values
- Handles all ControlMode enum values (Automatic, Disabled, Manual,
Override); UI sets Automatic/Disabled but preserves Manual/Override
when read from server
- Type-safe parameters (number | null instead of string coercion)
3. Toast composable and global plugin:
- useToast.ts (renamed from .js) uses bootstrap-vue-next useToast()
with TypeScript types; keeps successToast/errorToast API with
i18n titles
- Type restricted to string for simplicity; includes TODO for
potential VNode support expansion if needed
- src/plugins/toast.js continues to expose global $toast for
Options API
- BVToastMixin.js updated to use modelValue and extract VNode
content for consistency with bootstrap-vue-next 0.40.8
- Both implementations use isStatus: true for consistent toast
styling with status icons
4. Views modernization:
- Refactors src/views/ResourceManagement/Power.vue to use
<script setup>, usePowerControl(), and the new toast composable;
submitForm uses try/catch and
t('pageServerPowerOperations.toast.*') for success/error toasts
- Implements value caching to preserve user's typed input when
toggling power cap checkbox on/off
- Guards form sync watcher with v$.value?.$dirty check to prevent
overwriting in-progress edits during background refetch
- Loader semantics: show on first load (isLoading) and mutations,
but render cached data instantly on subsequent visits with silent
background refetch (avoids flicker)
- Renamed validator from 'between' to 'withinPowerCapRange' to
avoid confusion with Vuelidate's built-in validator
- Handles all ControlMode values (Automatic, Disabled, Manual,
Override) in form state synchronization
- Refactors src/views/Overview/OverviewPower.vue to read from the
power control composable instead of Vuex; implements settled
computed to emit overview-power-complete only when chassis
collection is fetched AND either no EnvironmentMetrics exists or
metrics query has completed (prevents premature completion)
- Shows power cap for all active control modes (Automatic, Manual,
Override)
- Removes mapState/mapActions usage and related Vuex wiring
5. Store cleanup and typing:
- Deletes src/store/modules/ResourceManagement/PowerControlStore.js
- Removes PowerControlStore registration from src/store/index.js
- Updates src/store/api.d.ts to match actual implementation
(set_auth_token with snake_case, accepts string | null |
undefined)
- Adds src/i18n.d.ts to provide basic typing for the shared api
Tested-by: Manual testing on development server
- Power consumption and cap values load correctly from
EnvironmentMetrics with automatic 30-second polling (refetchInterval)
when tab is visible
- Min and max power cap values reflect dynamic limits from Redfish
- Updating the power cap and enable state sends correct SetPoint and
ControlMode values; SetPoint is omitted when disabling
- All ControlMode values (Automatic, Disabled, Manual, Override) are
handled correctly
- User's typed values are preserved when toggling power cap checkbox
- Form edits are not overwritten by background refetch (dirty state
guard)
- Success/error toasts show localized messages with consistent
modelValue-based timing and status icons
- Overview power card reflects updated power state; overview loader
waits for both chassis and metrics queries to settle before
completing
- Request cancellation works properly on component unmount
Change-Id: Ic61631efd8790150a5e2914822f1dd25bd77305a
Signed-off-by: Nikhil Ashoka <a.nikhil@ibm.com>
|
|
This commit updates the implementation to dynamically
discover all chassis and fetch sensors from each.
Changes include:
- Updated useSensors to use /redfish/v1/Chassis collection endpoint
- Fixed discoverParentsWithSubResource to properly check individual
chassis members for Sensors sub-resource
The implementation now automatically discovers all chassis, fetches
sensors from each, and deduplicates results by @odata.id.
Tested: Verified sensors display from all chassis in
multi-chassis systems
Change-Id: Idadaef1be1b019cdded52ce7debe6f5f795e985e
Signed-off-by: Nishant Tiwari <tiwari.nishant@ibm.com>
|
|
Introduce reusable Redfish API infrastructure and modernize the Sensors
page to use Vue 3 Composition API with TanStack Query, eliminating the
need for Vuex store patterns for server state management.
This change provides a foundation for migrating other hardware status
pages (Memory, Processors, Drives, etc.) to a more maintainable and
performant architecture.
Key changes:
1. Generic Redfish composables (src/api/composables/):
- useRedfishRoot.ts: Caches ServiceRoot and detects OData support
- useRedfishCollection.ts: Smart collection fetcher with OData
$expand/$select support and graceful fallback
- useAllSubResources.ts: Generic pattern for fetching nested
resources from parent collections
2. Sensors page modernization:
- Migrated from Vuex store to TanStack Query (Vue Query)
- Created useSensors.ts composable for data fetching
- Removed legacy Thermal and PowerSubsystem endpoints
- Now uses only modern /Chassis/{id}/Sensors collection
- Maintains existing UI/UX with Bootstrap Vue table
3. TypeScript support:
- Added tsconfig.json and webpack ts-loader configuration
- Created required Redfish type definitions
- Preserves Redfish PascalCase property names
4. Performance optimizations:
- Auto-detects and uses OData $expand for fewer API calls
- Implements automatic caching and deduplication
- Smart retry logic with exponential backoff
- 30-second stale time with 5-minute garbage collection
Benefits for future development:
- The generic composables are designed for reuse across components:
// Fetch all Memory from all Systems
useAllSubResources<Memory>('/redfish/v1/Systems', 'Memory')
// Fetch all Drives from all Storage
useAllSubResources<Drive>('/redfish/v1/Storage', 'Drives')
- Implemented TypeScript types
- Reuses existing Bootstrap table components
- Preserves existing UI/UX
- Focuses on infrastructure reusability
This pattern eliminates boilerplate Vuex store code and provides
better developer experience with automatic loading states, error
handling, and background refetching.
Tested-by: Manual testing on development server
- Sensors page loads correctly
- OData optimization works when supported
- Graceful fallback when OData unavailable
- All table functionality preserved (sorting, filtering,
export, cancel and searching)
Change-Id: Id605319140f607b295d24085f3681f09ac0d5ebd
Signed-off-by: Nishant Tiwari <tiwari.nishant@ibm.com>
|
