1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
|
#include "ethernet.hpp"
#include "http_response.hpp"
#include <nlohmann/json.hpp>
#include <cstddef>
#include <string>
#include <variant>
#include <vector>
#include <gmock/gmock.h>
#include <gtest/gtest.h>
namespace redfish
{
namespace
{
using ::testing::IsEmpty;
TEST(Ethernet, parseAddressesEmpty)
{
std::vector<std::variant<nlohmann::json::object_t, std::nullptr_t>> addr;
std::vector<IPv4AddressData> existingAddr;
std::vector<AddressPatch> addrOut;
std::string gatewayOut;
crow::Response res;
EXPECT_TRUE(parseAddresses(addr, existingAddr, res, addrOut, gatewayOut));
EXPECT_THAT(addrOut, IsEmpty());
EXPECT_THAT(gatewayOut, IsEmpty());
}
// Create full entry with all fields
TEST(Ethernet, parseAddressesCreateOne)
{
std::vector<std::variant<nlohmann::json::object_t, std::nullptr_t>> addr;
nlohmann::json::object_t eth;
eth["Address"] = "1.1.1.2";
eth["Gateway"] = "1.1.1.1";
eth["SubnetMask"] = "255.255.255.0";
addr.emplace_back(eth);
std::vector<IPv4AddressData> existingAddr;
std::vector<AddressPatch> addrOut;
std::string gatewayOut;
crow::Response res;
EXPECT_TRUE(parseAddresses(addr, existingAddr, res, addrOut, gatewayOut));
EXPECT_EQ(addrOut.size(), 1);
EXPECT_EQ(addrOut[0].address, "1.1.1.2");
EXPECT_EQ(addrOut[0].gateway, "1.1.1.1");
EXPECT_EQ(addrOut[0].prefixLength, 24);
EXPECT_EQ(addrOut[0].existingDbusId, "");
EXPECT_EQ(addrOut[0].operation, AddrChange::Update);
EXPECT_EQ(gatewayOut, "1.1.1.1");
}
// Missing gateway should default to no gateway
TEST(Ethernet, parseAddressesCreateOneNoGateway)
{
std::vector<std::variant<nlohmann::json::object_t, std::nullptr_t>> addr;
nlohmann::json::object_t eth;
eth["Address"] = "1.1.1.2";
eth["SubnetMask"] = "255.255.255.0";
addr.emplace_back(eth);
std::vector<IPv4AddressData> existingAddr;
std::vector<AddressPatch> addrOut;
std::string gatewayOut;
crow::Response res;
EXPECT_TRUE(parseAddresses(addr, existingAddr, res, addrOut, gatewayOut));
EXPECT_EQ(addrOut.size(), 1);
EXPECT_EQ(addrOut[0].address, "1.1.1.2");
EXPECT_EQ(addrOut[0].gateway, "");
EXPECT_EQ(addrOut[0].prefixLength, 24);
EXPECT_EQ(addrOut[0].existingDbusId, "");
EXPECT_EQ(addrOut[0].operation, AddrChange::Update);
EXPECT_EQ(gatewayOut, "");
}
// Create two entries with conflicting gateways.
TEST(Ethernet, conflictingGatewaysNew)
{
std::vector<std::variant<nlohmann::json::object_t, std::nullptr_t>> addr;
nlohmann::json::object_t eth;
eth["Address"] = "1.1.1.2";
eth["Gateway"] = "1.1.1.1";
eth["SubnetMask"] = "255.255.255.0";
addr.emplace_back(eth);
eth["Gateway"] = "1.1.1.5";
addr.emplace_back(eth);
std::vector<IPv4AddressData> existingAddr;
std::vector<AddressPatch> addrOut;
std::string gatewayOut;
crow::Response res;
EXPECT_FALSE(parseAddresses(addr, existingAddr, res, addrOut, gatewayOut));
}
// Create full entry with all fields
TEST(Ethernet, conflictingGatewaysExisting)
{
std::vector<std::variant<nlohmann::json::object_t, std::nullptr_t>> addr;
nlohmann::json::object_t eth;
addr.emplace_back(eth);
eth["Address"] = "1.1.1.2";
eth["Gateway"] = "1.1.1.1";
eth["SubnetMask"] = "255.255.255.0";
addr.emplace_back(eth);
std::vector<IPv4AddressData> existingAddr;
IPv4AddressData& existing = existingAddr.emplace_back();
existing.id = "my_ip_id";
existing.origin = "Static";
existing.gateway = "192.168.1.1";
std::vector<AddressPatch> addrOut;
std::string gatewayOut;
crow::Response res;
EXPECT_FALSE(parseAddresses(addr, existingAddr, res, addrOut, gatewayOut));
}
// Missing address should fail
TEST(Ethernet, parseMissingAddress)
{
std::vector<std::variant<nlohmann::json::object_t, std::nullptr_t>> addr;
nlohmann::json::object_t eth;
eth["SubnetMask"] = "255.255.255.0";
addr.emplace_back(eth);
std::vector<IPv4AddressData> existingAddr;
std::vector<AddressPatch> addrOut;
std::string gatewayOut;
crow::Response res;
EXPECT_FALSE(parseAddresses(addr, existingAddr, res, addrOut, gatewayOut));
}
// Missing subnet should fail
TEST(Ethernet, parseAddressesMissingSubnet)
{
std::vector<std::variant<nlohmann::json::object_t, std::nullptr_t>> addr;
nlohmann::json::object_t eth;
eth["Address"] = "1.1.1.2";
addr.emplace_back(eth);
std::vector<IPv4AddressData> existingAddr;
std::vector<AddressPatch> addrOut;
std::string gatewayOut;
crow::Response res;
EXPECT_FALSE(parseAddresses(addr, existingAddr, res, addrOut, gatewayOut));
}
// With one existing address, and a null, it should request deletion
// and clear gateway
TEST(Ethernet, parseAddressesDeleteExistingOnNull)
{
std::vector<std::variant<nlohmann::json::object_t, std::nullptr_t>> addr;
addr.emplace_back(nullptr);
std::vector<IPv4AddressData> existingAddr;
IPv4AddressData& existing = existingAddr.emplace_back();
existing.id = "my_ip_id";
existing.origin = "Static";
std::vector<AddressPatch> addrOut;
std::string gatewayOut;
crow::Response res;
EXPECT_TRUE(parseAddresses(addr, existingAddr, res, addrOut, gatewayOut));
EXPECT_EQ(addrOut.size(), 1);
EXPECT_EQ(addrOut[0].existingDbusId, "my_ip_id");
EXPECT_EQ(addrOut[0].operation, AddrChange::Delete);
EXPECT_EQ(gatewayOut, "");
}
TEST(Ethernet, parseAddressesDeleteExistingOnShortLength)
{
// With one existing address, and an input of len(0) it should request
// deletion and clear gateway
std::vector<std::variant<nlohmann::json::object_t, std::nullptr_t>> addr;
std::vector<IPv4AddressData> existingAddr;
IPv4AddressData& existing = existingAddr.emplace_back();
existing.id = "my_ip_id";
existing.origin = "Static";
std::vector<AddressPatch> addrOut;
std::string gatewayOut;
crow::Response res;
EXPECT_TRUE(parseAddresses(addr, existingAddr, res, addrOut, gatewayOut));
EXPECT_EQ(addrOut.size(), 1);
EXPECT_EQ(addrOut[0].existingDbusId, "my_ip_id");
EXPECT_EQ(addrOut[0].operation, AddrChange::Delete);
EXPECT_EQ(gatewayOut, "");
}
} // namespace
} // namespace redfish
|
