| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
For some reason, validator run at the recent bmcweb bump[1] wasn't able
to download the schemas and hit:
```
/redfish/v1/Fabrics
FabricCollection
Pass: 5
Failure: 1
Show Results
Show Payload
NameValueResult
Schema Error: Unable to locate the schema definition for the 'Fabric.Fabric' type.FAILMembers@odata.count1PASSMembers@odata.nextLink[Not Present]SKIPNameFabric CollectionPASSOem[Not Present]SKIP
```
Fabric was added at 3132dacead0.
Long term it would be nice to get rid of this only install certain
schemas.. Separate discussion.
[1]: https://gerrit.openbmc.org/c/openbmc/openbmc/+/93063
Commands ran:
cd redfish-core/schema/dmtf/json-schema-installed
ln -fs ../json-schema/Fabric.v1_4_0.json Fabricv1_4_0.json
cd redfish-core/schema/dmtf/installed
ln -fs ../csdl/Fabric_v1.xml Fabric_v1.xml
Tested: Inspection only.
Change-Id: I8a36b978b7228238f7011beefd7d03f24a7839b1
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
dmtf.org is now blocking downloading from wget [1]. Sure they will get a
fix but we are close to passing the validator without the bundle, since
we already install ~98% of the schemas we need.
The errors we were seeing were:
```
[Link to: /redfish/v1/Chassis/chassis/NetworkAdapters]
Schema Error: Unable to locate the schema definition for the 'NetworkAdapterCollection.NetworkAdapterCollection' type.
```
```
2026-04-29 09:22:37,315 - redfish - ERROR - FAIL - /Fabrics ([Link to: /redfish/v1/Fabrics]): Schema Error: Unable to locate the schema definition for the 'FabricCollection.FabricCollection' type.
```
And that makes sense.. We use the schemas at [2] and [3].
```
cd redfish-core/schema/dmtf/json-schema-installed
ln -fs ../json-schema/NetworkAdapterCollection.json NetworkAdapterCollection.json
...
cd redfish-core/schema/dmtf/installed
ln -fs ../csdl/FabricCollection_v1.xml FabricCollection_v1.xml
...
```
Long term it would be nice to get rid of this only install certain
schemas.. Separate discussion.
[1] https://github.com/DMTF/Redfish-Service-Validator/issues/664
[2] https://github.com/openbmc/bmcweb/blob/48eca7bbb0cdb736cd4495c512586ceead65e09c/redfish-core/lib/fabric.hpp#L194
[3] https://github.com/openbmc/bmcweb/blob/48eca7bbb0cdb736cd4495c512586ceead65e09c/redfish-core/lib/network_adapter.hpp#L393
Tested: Visual only.
```
lrwxrwxrwx 1 gmills gmills 40 Jan 26 15:36 FabricAdapter.v1_5_3.json -> ../json-schema/FabricAdapter.v1_5_3.json
lrwxrwxrwx 1 gmills gmills 43 Jan 26 15:36 FabricAdapterCollection.json -> ../json-schema/FabricAdapterCollection.json
lrwxrwxrwx 1 gmills gmills 36 Apr 29 11:47 FabricCollection.json -> ../json-schema/FabricCollection.json
```
```
lrwxrwxrwx 1 gmills gmills 27 Jan 26 15:36 MetricReport_v1.xml -> ../csdl/MetricReport_v1.xml
lrwxrwxrwx 1 gmills gmills 39 Apr 29 12:01 NetworkAdapterCollection_v1.xml -> ../csdl/NetworkAdapterCollection_v1.xml
lrwxrwxrwx 1 gmills gmills 40 Jan 26 15:36 OperatingConfigCollection_v1.xml -> ../csdl/OperatingConfigCollection_v1.xml
```
Change-Id: If63d733323acd5239405cac2e4b6317131c88cd3
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
This fixes `update_schemas.py` so that the existing installed csdl and
json symlinks are to be kept and also to be updated with the matching
json schema version when DMTF schema version is upgraded.
This commit also uses the symlinks to the closed relative paths like
- `../schema/dmtf/installed/<schema>.xml -> ../csdl/<schema>.xml`
- `../schema/dmtf/json-schema-installed/<json-file>.json ->
../json-schema/<json-file>.json`
Tested:
- Change VERSION in `update_schemas.py` and verify the generated files
- CI passes
- Redfish Service Validator passes
Change-Id: Ib7fede7e4c39bdfc13da227eb1e737d96b6c2b5e
Signed-off-by: Myung Bae <myungbae@us.ibm.com>
|
|
This fixes the missing Oem/OpenBMC JsonSchema file installation.
Tested:
- Check JsonSchemas to have the enabled OpenBMC schemas
```
curl -k -X GET https::/${bmc}/redfish/v1/JsonSchemas/OpenBMCAccountService
curl -k -X GET https::/${bmc}/redfish/v1/JsonSchemas/OpenBMCManager
curl -k -X GET https::/${bmc}/redfish/v1/JsonSchemas/OpenBMCComputerSystem
```
Change-Id: Ia13b5c5d1626ee5648ddce5cd62375c8e3e09e75
Signed-off-by: Myung Bae <myungbae@us.ibm.com>
|
|
These symlinks no longer point to anything useful.
Tested:
Code compiles. GET /redfish/v1/\$metadata returns correct data.
Change-Id: I29853e18f85d9509e171b0460792ac788fd503ec
Signed-off-by: Ed Tanous <etanous@nvidia.com>
|
|
The OpenBMC OEM schemas have had many things wrong since their creation,
to the point where nobody could be using them to generate values. This
commit fixes the issues, namely.
OemManager schema and namespace are renamed to OpenBMCManager, in line
with the Redfish specification around OEM naming conventions.
OpenBMCManager now includes versions, which is a partial fix for #184.
json-schemas are regenerated from the CSDL to json script in
Redfish-Tools, rather than being handmade. This also introduces
versions in the json-schema.
Tested:
Redfish service validator passes.
Change-Id: I18f7d0445105a361775c04ae614d6ae2e297bbf6
Signed-off-by: Ed Tanous <ed@tanous.net>
|
|
Which schemas are installed should be selectable in both a meson config,
and trivially by forks. This commit gets us closer to that idea.
It does it in several ways, first, the code for generating
JsonSchemaFile resources has been changed to be generated at runtime,
based on files on disk. This is slightly slower, but allows installing
schemas from anywhere, and matches the CSDL handling.
Next, the schema folders are separated into two sets
csdl -> This includes the complete schema pack from dmtf
installed -> this includes only the schemas the bmc includes
Similar folders exist for json-schema and json-schema-installed.
This allows any additional schemas to be a single symlink addition.
Note, this also checks in all of the dmtf json schemas, not just the
versions we use. This allows us to update the schema pack without
needing to break our versions we ship.
Because the static files are now selectable, all files need to be in a
folder. This forces the css and image for the redfish built-in gui to
be moved.
Tested:
/redfish/v1/JsonSchemas returns the correct result
/redfish/v1/JsonSchemas/UpdateService returns a JsonSchemaFile instance
/redfish/v1/JsonSchemas/UpdateService/UpdateService<version>json returns
the JsonSchemaFile contents.
Redfish service validator passes.
Change-Id: Ie96b2e4b623788dc2ec94eb40fcfd80325f0d826
Signed-off-by: Ed Tanous <ed@tanous.net>
|
