diff options
| author | Matthias Reichl <hias@horus.com> | 2017-11-08 23:03:32 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2017-11-11 00:26:03 +0300 |
| commit | 3d2b3c707b3f9516d6c183eb1ffbf02a6dc5dc98 (patch) | |
| tree | 9ebdedf52b977293827c54cda8610b2a3f49c099 /sound | |
| parent | 675c0ee514f56ea39f6f550299621aafe9a53fc0 (diff) | |
| download | linux-3d2b3c707b3f9516d6c183eb1ffbf02a6dc5dc98.tar.xz | |
ASoC: bcm2835: Enforce full symmetry
bcm2835's configuration registers can't be changed when a stream
is running, which means asymmetric configurations aren't supported.
Channel and rate symmetry are already enforced by constraints
but samplebits had been missed.
As hw_params doesn't check for symmetry constraints by itself
and just returns success if a stream is running this led to
situations where asymmetric configurations were seeming to
succeed but of course didn't work because the hardware wasn't
configured at all.
Fix this by adding the missing samplerate symmetry constraint.
Signed-off-by: Matthias Reichl <hias@horus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/soc/bcm/bcm2835-i2s.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sound/soc/bcm/bcm2835-i2s.c b/sound/soc/bcm/bcm2835-i2s.c index f4b778ed350b..111b4ef7ce35 100644 --- a/sound/soc/bcm/bcm2835-i2s.c +++ b/sound/soc/bcm/bcm2835-i2s.c @@ -737,7 +737,8 @@ static struct snd_soc_dai_driver bcm2835_i2s_dai = { | SNDRV_PCM_FMTBIT_S32_LE }, .ops = &bcm2835_i2s_dai_ops, - .symmetric_rates = 1 + .symmetric_rates = 1, + .symmetric_samplebits = 1, }; static bool bcm2835_i2s_volatile_reg(struct device *dev, unsigned int reg) |