diff options
| author | Liam Girdwood <liam.r.girdwood@linux.intel.com> | 2018-06-14 22:26:42 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2018-06-18 14:09:29 +0300 |
| commit | e01b4f624278d5efe5fb5da585ca371947b16680 (patch) | |
| tree | f19203f21323945923fbe0f31f814f6a96f4c38b /sound/soc | |
| parent | 5544717d416d9a095edc616be789bdab69e284dc (diff) | |
| download | linux-e01b4f624278d5efe5fb5da585ca371947b16680.tar.xz | |
ASoC: dapm: Fix potential DAI widget pointer deref when linking DAIs
Sometime a component or topology may configure a DAI widget with no
private data leading to a dev_dbg() dereferencne of this data.
Fix this to check for non NULL private data and let users know if widget
is missing DAI.
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc')
| -rw-r--r-- | sound/soc/soc-dapm.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index 36a39ba30226..8ede773b1db8 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -4073,6 +4073,13 @@ int snd_soc_dapm_link_dai_widgets(struct snd_soc_card *card) continue; } + /* let users know there is no DAI to link */ + if (!dai_w->priv) { + dev_dbg(card->dev, "dai widget %s has no DAI\n", + dai_w->name); + continue; + } + dai = dai_w->priv; /* ...find all widgets with the same stream and link them */ |