diff options
| author | Andrey Konovalov <andreyknvl@google.com> | 2017-03-29 17:11:21 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-03-30 21:03:59 +0300 |
| commit | 8f8d28e4d6d815a391285e121c3a53a0b6cb9e7b (patch) | |
| tree | 624d40509e1e573450288151977e59c36da05fc6 /net | |
| parent | 2b6867c2ce76c596676bec7d2d525af525fdc6e2 (diff) | |
| download | linux-8f8d28e4d6d815a391285e121c3a53a0b6cb9e7b.tar.xz | |
net/packet: fix overflow in check for tp_frame_nr
When calculating rb->frames_per_block * req->tp_block_nr the result
can overflow.
Add a check that tp_block_size * tp_block_nr <= UINT_MAX.
Since frames_per_block <= tp_block_size, the expression would
never overflow.
Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/packet/af_packet.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index 2323ee35dc09..3ac286ebb2f4 100644 --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c @@ -4205,6 +4205,8 @@ static int packet_set_ring(struct sock *sk, union tpacket_req_u *req_u, rb->frames_per_block = req->tp_block_size / req->tp_frame_size; if (unlikely(rb->frames_per_block == 0)) goto out; + if (unlikely(req->tp_block_size > UINT_MAX / req->tp_block_nr)) + goto out; if (unlikely((rb->frames_per_block * req->tp_block_nr) != req->tp_frame_nr)) goto out; |